Re: [PATCH v2 1/2] Export usb_serial_generic_write_room for use in modules

[Johan Hovold <jhovold@gmail.com>]

On Mon, Oct 25, 2010 at 09:57:37PM +0200, Alon Ziv wrote:
> Hi Johan,
> 
> On 10/25/2010 01:20 PM, you wrote:
> >> Any module using usb_serial_generic_write (which is already exported)
> >> had better use usb_serial_generic_write_room as well, or be prepared
> >> for failures.
> >
> > As I mentioned elsewhere, this description is a little misleading as any
> > driver can use the generic write_room implementation simply by not
> > overriding it (i.e. leaving the write_room field undefined).
> >
> > There is nothing wrong with exporting it, but it is currently only your
> > other patch that requires that. Could you perhaps just modify the patch
> > description?
> >
> Well... the latest changes (due to your review) removed even my driver's
> use of this function. So probably there is no need to export it (at
> least not yet).
> 
> If you prefer that I leave the export in place (and unused), I will
> clarify the patch description.

There's no need to export it unless it's got a use (and it's easily done
later should need arise).

I'm off for a week to UK (Embedded Linux Conference and some holidays)
with limited mail access from tomorrow so I'll have to get back to you
on your other mail when I'm back.

Thanks,
Johan