Re: [NAK] Re: [PATCH -v2 9/9] ACPI, APEI, Generic Hardware Error Source POLL/IRQ/NMI notification type support

Andi Kleen
2010-10-25T09:19:24Z

> > Sigh, please integrate all this into EDAC (drivers/edac/) properly, instead of
> > turning it into YET ANOTHER hardware vendor special hw-errors thing. We can do
> > better than this. EDAC is almost there: it has support for Nehalem, AMD, a couple
> > of older chips.
>
> I think APEI (ACPI Platform Error Interface) is another driver. Why
> integrate two drivers?

Yes they're solving quite different problems from EDAC with different
interfaces and for different devices in the ACPI space.

The earlier nack seems to be based on a lot of confusion on what the code
does.

Besides it nacks code in areas Ingo doesn't even maintain.
(if he's allowed to nack random other code he doesn't like do I get this
right too? :-)

> > einj.c: it's about the 3rd separate 'error injection' concept that got introduced
> > ...
>
> EINJ is a true platform feature, not just software feature. We need to
> support it to debug various hardware error features.

Also having multiple error injecting interfaces is a good thing.

Error injection is hard and one size definitely doesn't fit all. You need
quite different ones depending on what you want to test, in which
context etc.

For hwpoison we currently have three different injectors at least and I expect
that to even grow more in the future as different features get added.

-Andi

--
ak@linux.intel.com -- Speaking for myself only.