Re: [NAK] Re: [PATCH -v2 9/9] ACPI, APEI, Generic Hardware Error Source POLL/IRQ/NMI notification type support

Thomas Gleixner
2010-10-25T16:39:26Z

On Mon, 25 Oct 2010, Andi Kleen wrote:
> > > Sigh, please integrate all this into EDAC (drivers/edac/) properly, instead of
> > > turning it into YET ANOTHER hardware vendor special hw-errors thing. We can do
> > > better than this. EDAC is almost there: it has support for Nehalem, AMD, a couple
> > > of older chips.
> >
> > I think APEI (ACPI Platform Error Interface) is another driver. Why
> > integrate two drivers?
>
> Yes they're solving quite different problems from EDAC with different
> interfaces and for different devices in the ACPI space.
>
> The earlier nack seems to be based on a lot of confusion on what the code
> does.

Errm. That patch series carries a lot of other weird stuff including a
new "memory allocator", a new ioremap implementation private to the
acpi code and new character device driver for hardware error
reporting.

> Subject: [PATCH -v2 5/9] Hardware error device core
>
> Hardware error device is a kind of device which can report hardware
> errors. The examples of hardware error device include APEI GHES, PCIe
> AER, etc.
>
> Hardware error device core in this patch provides common services for
> various hardware error devices.

But it does not even make an attempt to explain why this error
reporting cannot be done via the existing interfaces and why they
can't be extended to fit your needs. What's so special about APEI GHES
and PCIe AER that we need another incompatible "just fits your needs"
ABI which makes tooling folks deal with another completely different
interface ?

The only explanation I have is that you are simply not willing to work
with others and this is just another proof of a repeating problem.

Thanks,

tglx