public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Bob Picco <bpicco@redhat.com>,
	Brian Bloniarz <phunge0@hotmail.com>,
	Charles Butterfield <charles.butterfield@nextcentury.com>,
	Denys Vlasenko <dvlasenk@redhat.com>, Ingo Molnar <mingo@elte.hu>,
	linux-pci@vger.kernel.org,
	"Horst H. von Brand" <vonbrand@inf.utfsm.cl>,
	"H. Peter Anvin" <hpa@zytor.com>,
	linux-kernel@vger.kernel.org, Stefan Becker <chemobejk@gmail.com>,
	Chuck Ebbert <cebbert@redhat.com>,
	Fabrice Bellet <fabrice@bellet.info>,
	Yinghai Lu <yinghai@kernel.org>,
	Leann Ogasawara <leann.ogasawara@canonical.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: [PATCH v5 2/9] resources: factor out resource_clip() to simplify find_resource()
Date: Tue, 26 Oct 2010 15:41:18 -0600	[thread overview]
Message-ID: <20101026214118.29808.48356.stgit@bob.kio> (raw)
In-Reply-To: <20101026214033.29808.15272.stgit@bob.kio>


This factors out the min/max clipping to simplify find_resource().
No functional change.

Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
---

 kernel/resource.c |   15 +++++++++++----
 1 files changed, 11 insertions(+), 4 deletions(-)


diff --git a/kernel/resource.c b/kernel/resource.c
index 7dc8ad2..26e9f25 100644
--- a/kernel/resource.c
+++ b/kernel/resource.c
@@ -365,6 +365,15 @@ static resource_size_t simple_align_resource(void *data,
 	return avail->start;
 }
 
+static void resource_clip(struct resource *res, resource_size_t min,
+			  resource_size_t max)
+{
+	if (res->start < min)
+		res->start = min;
+	if (res->end > max)
+		res->end = max;
+}
+
 /*
  * Find empty slot in the resource tree given range and alignment.
  */
@@ -394,10 +403,8 @@ static int find_resource(struct resource *root, struct resource *new,
 			tmp.end = this->start - 1;
 		else
 			tmp.end = root->end;
-		if (tmp.start < min)
-			tmp.start = min;
-		if (tmp.end > max)
-			tmp.end = max;
+
+		resource_clip(&tmp, min, max);
 		tmp.start = ALIGN(tmp.start, align);
 
 		tmp.start = alignf(alignf_data, &tmp, size, align);


  parent reply	other threads:[~2010-10-26 21:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-26 21:41 [PATCH v5 0/9] PCI: allocate space top-down, not bottom-up Bjorn Helgaas
2010-10-26 21:41 ` [PATCH v5 1/9] resources: add a default alignf to simplify find_resource() Bjorn Helgaas
2010-10-26 21:41 ` Bjorn Helgaas [this message]
2010-10-26 21:41 ` [PATCH v5 3/9] resources: ensure callback doesn't allocate outside available space Bjorn Helgaas
2010-10-26 21:41 ` [PATCH v5 4/9] resources: handle overflow when aligning start of available area Bjorn Helgaas
2010-10-26 21:41 ` [PATCH v5 5/9] resources: support allocating space within a region from the top down Bjorn Helgaas
2010-10-26 21:41 ` [PATCH v5 6/9] PCI: allocate bus resources " Bjorn Helgaas
2010-10-26 21:41 ` [PATCH v5 7/9] x86/PCI: allocate space from the end of a region, not the beginning Bjorn Helgaas
2010-10-26 21:41 ` [PATCH v5 8/9] x86: update iomem_resource end based on CPU physical address capabilities Bjorn Helgaas
2010-10-26 21:41 ` [PATCH v5 9/9] x86: allocate space within a region top-down Bjorn Helgaas
2010-10-26 22:34   ` Jesse Barnes
2010-10-27  6:23     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101026214118.29808.48356.stgit@bob.kio \
    --to=bjorn.helgaas@hp.com \
    --cc=bpicco@redhat.com \
    --cc=cebbert@redhat.com \
    --cc=charles.butterfield@nextcentury.com \
    --cc=chemobejk@gmail.com \
    --cc=dvlasenk@redhat.com \
    --cc=fabrice@bellet.info \
    --cc=hpa@zytor.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=leann.ogasawara@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=phunge0@hotmail.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=vonbrand@inf.utfsm.cl \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox