From: Grant Likely <grant.likely@secretlab.ca>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Dinh.Nguyen@freescale.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux@arm.linux.org.uk,
s.hauer@pengutronix.de, valentin.longchamp@epfl.ch,
daniel@caiaq.de, amit.kucheria@canonical.com
Subject: Re: [PATCH] ARM: imx: Add some core definitions for MX53
Date: Wed, 27 Oct 2010 11:22:53 +0100 [thread overview]
Message-ID: <20101027102253.GA7822@angua.secretlab.ca> (raw)
In-Reply-To: <20101027090921.GB8554@pengutronix.de>
On Wed, Oct 27, 2010 at 11:09:21AM +0200, Uwe Kleine-König wrote:
> Hello,
>
> On Wed, Oct 27, 2010 at 09:29:59AM +0100, Grant Likely wrote:
> > > ---
> > > arch/arm/plat-mxc/include/mach/iomux-mx53.h | 301 +++++++++++++++++++
> > > arch/arm/plat-mxc/include/mach/mx53.h | 433 +++++++++++++++++++++++++++
> >
> > Hi Dinh.
> >
> > In general, these definitions should not be added until they are
> > actually needed by driver code.
> ack.
>
> > Also, from my understanding, the mx53 is very similar to the mx51.
> > If I'm correct, then they should be sharing the same set of #defines.
> Note, I asked for a seperate header file. See
> http://thread.gmane.org/gmane.linux.kernel/1051001/focus=1051352
For the record, I disagree with that approach. The approach I would
take is for the imx53 code to use the imx51 defines by default, and to
only define imx53 variants where there are differences. Otherwise the
code to support imx53 has to be completely divergent from imx51
because the defines are different symbols.
g.
next prev parent reply other threads:[~2010-10-27 10:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-26 18:53 [PATCH] ARM: imx: Add some core definitions for MX53 Dinh.Nguyen
2010-10-26 19:10 ` Uwe Kleine-König
2010-10-26 22:37 ` Nguyen Dinh-R00091
2010-10-27 8:29 ` Grant Likely
2010-10-27 9:09 ` Uwe Kleine-König
2010-10-27 10:22 ` Grant Likely [this message]
2010-10-27 13:22 ` Sascha Hauer
2010-10-27 13:33 ` Eric Bénard
2010-10-27 13:56 ` Sascha Hauer
2010-10-27 14:57 ` Nguyen Dinh-R00091
2010-10-27 16:31 ` Sascha Hauer
2010-10-27 23:44 ` Robert Schwebel
2010-10-27 13:36 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101027102253.GA7822@angua.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=Dinh.Nguyen@freescale.com \
--cc=amit.kucheria@canonical.com \
--cc=daniel@caiaq.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=s.hauer@pengutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
--cc=valentin.longchamp@epfl.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox