* Re: [patch 116/176] fs: allow for more than 2^31 files
[not found] <201010262122.o9QLMiZG016728@imap1.linux-foundation.org>
@ 2010-10-27 11:59 ` Christoph Hellwig
2010-10-27 12:46 ` Eric Dumazet
0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2010-10-27 11:59 UTC (permalink / raw)
To: akpm; +Cc: torvalds, eric.dumazet, davem, hch, holt, viro, linux-kernel
This patch breaks the binary sysctl ABI. It probably doesn't matter
as no one actually used it, but it might be better idea to just remove
this node from the binary sysctl tree.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch 116/176] fs: allow for more than 2^31 files
2010-10-27 11:59 ` [patch 116/176] fs: allow for more than 2^31 files Christoph Hellwig
@ 2010-10-27 12:46 ` Eric Dumazet
0 siblings, 0 replies; 2+ messages in thread
From: Eric Dumazet @ 2010-10-27 12:46 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: akpm, torvalds, davem, holt, viro, linux-kernel
Le mercredi 27 octobre 2010 à 13:59 +0200, Christoph Hellwig a écrit :
> This patch breaks the binary sysctl ABI. It probably doesn't matter
> as no one actually used it, but it might be better idea to just remove
> this node from the binary sysctl tree.
>
Good point
To be precise, sysctl() truncates the value to low order 32bit value,
because it internally uses simple_strtoul(), then a put_user()
An old binary using sysctl() to fetch FS_MAXFILE could break on SGI
machines. I am not sure we should remove sysctl FS_MAXFILE because of
this rare case.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-10-27 12:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <201010262122.o9QLMiZG016728@imap1.linux-foundation.org>
2010-10-27 11:59 ` [patch 116/176] fs: allow for more than 2^31 files Christoph Hellwig
2010-10-27 12:46 ` Eric Dumazet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox