From: Andrew Morton <akpm@linux-foundation.org>
To: Robin Holt <holt@sgi.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
Davide Libenzi <davidel@xmailserver.org>,
linux-kernel@vger.kernel.org,
Pekka Enberg <penberg@cs.helsinki.fi>
Subject: Re: [Patch] Convert max_user_watches to long.
Date: Wed, 27 Oct 2010 16:45:02 -0700 [thread overview]
Message-ID: <20101027164502.d6e2068d.akpm@linux-foundation.org> (raw)
In-Reply-To: <20101027190921.059806977@gulag1.americas.sgi.com>
On Wed, 27 Oct 2010 14:09:15 -0500
Robin Holt <holt@sgi.com> wrote:
> On a 16TB machine, max_user_watches has an integer overflow. Convert it
> to use a long and handle the associated fallout.
>
hand-wavy reality check:
Are the existing defaults sane? How well does the code perform with a
few billion watches?
Is the expected use case one-watch-per-user-per-fd? If so, then
perhaps the max number of user_watches should have some realtionship
with the max number of fds?
next prev parent reply other threads:[~2010-10-27 23:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20101027190914.146006767@gulag1.americas.sgi.com>
2010-10-27 19:09 ` [Patch] Convert max_user_watches to long Robin Holt
2010-10-27 19:31 ` Davide Libenzi
2010-10-27 23:45 ` Andrew Morton [this message]
2010-10-28 2:03 ` Davide Libenzi
2010-10-28 4:08 ` Andrew Morton
2010-10-01 20:01 max_user_watches overflows on 16TB system Robin Holt
2010-10-01 20:37 ` Davide Libenzi
2010-10-02 3:04 ` Eric W. Biederman
2010-10-02 14:04 ` Davide Libenzi
2010-10-04 19:44 ` [Patch] Convert max_user_watches to long Robin Holt
2010-10-06 2:21 ` Davide Libenzi
2010-10-09 7:50 ` Robin Holt
2010-10-10 19:05 ` Randy Dunlap
2010-10-11 4:49 ` Davide Libenzi
2010-10-14 17:15 ` Robin Holt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101027164502.d6e2068d.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=davidel@xmailserver.org \
--cc=ebiederm@xmission.com \
--cc=holt@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox