From: Al Viro <viro@ZenIV.linux.org.uk>
To: Chris Metcalf <cmetcalf@tilera.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: situation with signals
Date: Wed, 27 Oct 2010 22:37:45 +0100 [thread overview]
Message-ID: <20101027213745.GI19804@ZenIV.linux.org.uk> (raw)
In-Reply-To: <4CC89352.7020808@tilera.com>
On Wed, Oct 27, 2010 at 05:02:10PM -0400, Chris Metcalf wrote:
> I set aside this thread to look at when I had a minute, and I believe there
> is just one of the signal issues present in the tile code. The fix is to
> reset regs->fault to something other than the "syscall" fault type when
> exiting from do_signal(), so I'll submit that up for 2.6.37 shortly.
>
> Otherwise I think tile is doing things right, though I admit, the signal
> support is pretty deep magic generally.
FWIW, I'd do that in handle_signal() when hitting a syscall restart.
BTW, is everything in your pt_regs safe to modify? I.e. could bogus
values put there by sigreturn lead to something like kernel mode being
retained when you return from syscall or interesting flags being
set, etc.?
next prev parent reply other threads:[~2010-10-27 21:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-23 22:11 situation with signals Al Viro
2010-09-24 13:33 ` Arnd Bergmann
[not found] ` <9lYpY1#WLHA.1516@exchange1.tad.internal.tilera.com>
2010-10-27 21:02 ` Chris Metcalf
2010-10-27 21:37 ` Al Viro [this message]
2010-10-27 22:51 ` Chris Metcalf
2010-10-27 23:30 ` Al Viro
2010-10-28 19:47 ` [PATCH] arch/tile: don't allow user code to set the PL via ptrace or signal return Chris Metcalf
2010-10-28 19:03 ` [PATCH] arch/tile: correct double syscall restart for nested signals Chris Metcalf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101027213745.GI19804@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=arnd@arndb.de \
--cc=cmetcalf@tilera.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox