From: Ingo Molnar <mingo@elte.hu>
To: Anton Vorontsov <cbouatmailru@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
David Woodhouse <dwmw2@infradead.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Tony Lindgren <tony@atomide.com>,
linux-kernel@vger.kernel.org,
Grazvydas Ignotas <notasas@gmail.com>,
Felipe Balbi <balbi@ti.com>
Subject: -tip: origin tree build failure (battery-2.6.git related)
Date: Thu, 28 Oct 2010 08:54:57 +0200 [thread overview]
Message-ID: <20101028065457.GA29856@elte.hu> (raw)
In-Reply-To: <20101026144118.GA9335@oksana.dev.rtsoft.ru>
Hi,
* Anton Vorontsov <cbouatmailru@gmail.com> wrote:
> Hello Linus,
>
> Please pull battery-2.6.git tree to receive changes prepared for
> 2.6.37.
>
> There are three new drivers, various small cleanups and bug fixes.
> [...]
>
> Grazvydas Ignotas (1):
> power_supply: Add driver for TWL4030/TPS65950 BCI charger
Today's -tip fails to build due to upstream commit 2e727f1 ("power_supply: Add
driver for TWL4030/TPS65950 BCI charger"), on every x86 build that has this driver
enabled (for example allyesconfig or allmodconfig):
drivers/power/twl4030_charger.c: In function ‘twl4030_clear_set_boot_bci’:
drivers/power/twl4030_charger.c:105: error: ‘TWL4030_PM_MASTER_BOOT_BCI’ undeclared (first use in this function)
drivers/power/twl4030_charger.c:105: error: (Each undeclared identifier is reported only once
drivers/power/twl4030_charger.c:105: error: for each function it appears in.)
drivers/power/twl4030_charger.c: In function ‘twl4030_bci_have_vbus’:
drivers/power/twl4030_charger.c:137: error: ‘TWL4030_PM_MASTER_STS_HW_CONDITIONS’ undeclared (first use in this function)
The new driver does not build at its own commit point either, as the missing symbol
definition is simply not there. It appears that commit 2e727f1 could not have been
build-tested by anyone before it got upstream (let alone boot and functionality
tested). As a temporary workaround i'm disabling it in -tip.
Thanks,
Ingo
next prev parent reply other threads:[~2010-10-28 6:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-26 14:41 [GIT PULL] battery-2.6.git Anton Vorontsov
2010-10-28 6:54 ` Ingo Molnar [this message]
2010-10-28 7:07 ` -tip: origin tree build failure (battery-2.6.git related) Andrew Morton
2010-10-28 9:09 ` [GIT PULL] battery-2.6.git (a last minute fix) Anton Vorontsov
2010-10-28 20:58 ` Samuel Ortiz
2010-10-28 21:17 ` Anton Vorontsov
2010-10-28 22:26 ` Grazvydas Ignotas
2010-10-28 9:18 ` -tip: origin tree build failure (battery-2.6.git related) Grazvydas Ignotas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101028065457.GA29856@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=balbi@ti.com \
--cc=cbouatmailru@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=notasas@gmail.com \
--cc=sfr@canb.auug.org.au \
--cc=tony@atomide.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox