From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Jason Baron <jbaron@redhat.com>
Subject: [PATCH 8/8] jump label: Disable due to compiler bug
Date: Thu, 28 Oct 2010 09:55:56 -0400 [thread overview]
Message-ID: <20101028135648.944178348@goodmis.org> (raw)
In-Reply-To: 20101028135548.055490014@goodmis.org
[-- Attachment #1: 0008-jump-label-Disable-due-to-compiler-bug.patch --]
[-- Type: text/plain, Size: 1332 bytes --]
From: Jason Baron <jbaron@redhat.com>
Unfortunately, we found a compiler bug in the implementation of
'asm goto'. The bug can cause the kernel to crash.
For now, we are disabling jump labels with a big hammer. When the
gcc fix is committed, we will update the kernel with a better check
for either the version number it's fix in, or some detection of
whether gcc has the fix in place.
Signed-off-by: Jason Baron <jbaron@redhat.com>
LKML-Reference: <2d1b1d5d2b3930e1acb063cefffbcb2faf049854.1288212486.git.jbaron@redhat.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
include/linux/jump_label.h | 9 +++++++++
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/include/linux/jump_label.h b/include/linux/jump_label.h
index b3835f6..d9d367c 100644
--- a/include/linux/jump_label.h
+++ b/include/linux/jump_label.h
@@ -1,11 +1,20 @@
#ifndef _LINUX_JUMP_LABEL_H
#define _LINUX_JUMP_LABEL_H
+/*
+ * A compiler bug was found in the implementation of 'asm goto'. Thus,
+ * we are disabling it for now pending a better check for compiler version
+ * that fixes it.
+ */
+#if 0
+
#if defined(CC_HAVE_ASM_GOTO) && defined(CONFIG_HAVE_ARCH_JUMP_LABEL)
# include <asm/jump_label.h>
# define HAVE_JUMP_LABEL
#endif
+#endif
+
enum jump_label_type {
JUMP_LABEL_ENABLE,
JUMP_LABEL_DISABLE
--
1.7.1
prev parent reply other threads:[~2010-10-28 13:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-28 13:55 [PATCH 0/8] [GIT PULL] jump label: various fixes and updates Steven Rostedt
2010-10-28 13:55 ` [PATCH 1/8] jump label: Fix module __init section race Steven Rostedt
2010-10-28 13:55 ` [PATCH 2/8] jump label: Fix deadlock b/w jump_label_mutex vs. text_mutex Steven Rostedt
2010-10-28 13:55 ` [PATCH 3/8] jump label: Fix error with preempt disable holding mutex Steven Rostedt
2010-10-29 4:20 ` Masami Hiramatsu
2010-10-28 13:55 ` [PATCH 4/8] jump label: Make arch_jump_label_text_poke_early() optional Steven Rostedt
2010-10-29 20:37 ` David Miller
2010-10-29 20:48 ` David Daney
2010-10-28 13:55 ` [PATCH 5/8] jump label: Add MIPS support Steven Rostedt
2010-10-28 13:55 ` [PATCH 6/8] jump_label: Fix unaligned traps on sparc Steven Rostedt
2010-10-28 13:55 ` [PATCH 7/8] x86, ftrace: Use safe noops, drop trap test Steven Rostedt
2010-10-28 13:55 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101028135648.944178348@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox