From: Greg KH <greg@kroah.com>
To: Charles Manning <manningc2@actrix.gen.nz>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
linux-kernel@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: How do I add yaffs file system to mainline?
Date: Thu, 28 Oct 2010 10:49:32 -0700 [thread overview]
Message-ID: <20101028174932.GB2205@kroah.com> (raw)
In-Reply-To: <201010290641.13820.manningc2@actrix.gen.nz>
On Fri, Oct 29, 2010 at 06:41:13AM +1300, Charles Manning wrote:
> On Friday 29 October 2010 06:26:41 Randy Dunlap wrote:
> > On Fri, 29 Oct 2010 04:55:02 +1300 Charles Manning wrote:
> > > YAFFS has been used for many years as a third-party patch-in.
> > >
> > > I have recently been through the exercise of changing all the symbols to
> > > be more kernel friendly with the intention of mainlining into the linux
> > > tree.
> > >
> > > The code is in git at
> > > http://github.com/cdhmanning/linux-yaffs-integration/
> >
> > It's difficult to review & comment on a git tree.
> > We prefer patches via email for review.
> >
> > > Thanks to CELF and Google for sponsoring the effort so far.
> > >
> > > What still needs to be done to mainline this?
> > > Who do I need to approach?
> >
> > Either ask Stephen Rothwell to add the git tree to the linux-next daily
> > tree or ask Greg KH to add it to the drivers/staging/ area.
>
> Hi Randy
>
> Thanks for the response.
>
> At this stage I'm hoping for some high level feedback about code layout etc.
> and don't expect an immediate approval. I expect to do some further code
> cleansing before getting a green light.
>
> We're talking around 15k lines of code. Is a huge patch set the right way?
> I thought it would be more polite to invite people to look at git, rather
> than filling everyone's inboxes.
Have you read Documentation/SubmittingPatches and
Documentation/development_process/ which explains how to break up your
code and send it out for review properly?
No one is going to look at a random git tree with 15k lines of code for
a review, sorry. Would you?
thanks,
greg k-h
next prev parent reply other threads:[~2010-10-28 17:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-28 15:55 How do I add yaffs file system to mainline? Charles Manning
2010-10-28 17:26 ` Randy Dunlap
2010-10-28 17:41 ` Charles Manning
2010-10-28 17:49 ` Greg KH [this message]
2010-10-28 18:15 ` David Daney
2010-10-28 18:23 ` Greg KH
2010-10-28 17:44 ` Greg KH
2010-10-28 17:55 ` Charles Manning
2010-10-28 18:08 ` Greg KH
2010-10-28 18:29 ` Joe Perches
2010-10-28 18:31 ` Randy Dunlap
2010-10-28 18:38 ` Charles Manning
2010-10-28 18:40 ` Randy Dunlap
2010-10-29 19:16 ` James Cloos
-- strict thread matches above, loose matches on Subject: below --
2010-10-28 0:08 Charles Manning
2010-10-28 17:58 ` Corey Ashford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101028174932.GB2205@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manningc2@actrix.gen.nz \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox