public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Vasiliy Kulikov <segooon@gmail.com>,
	Iliyan Malchev <ibm@android.com>, Pavel Machek <pavel@ucw.cz>,
	Brian Swetland <swetland@google.com>, San Mehat <san@android.com>
Cc: kernel-janitors@vger.kernel.org, Tejun Heo <tj@kernel.org>,
	devel@driverdev.osuosl.org, Greg Kroah-Hartman <gregkh@suse.de>,
	linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 1/8] staging: dream: fix information leak to userland
Date: Thu, 28 Oct 2010 13:45:09 -0700	[thread overview]
Message-ID: <20101028204509.GC22785@kroah.com> (raw)
In-Reply-To: <1288296098-18936-1-git-send-email-segooon@gmail.com>

On Fri, Oct 29, 2010 at 12:01:37AM +0400, Vasiliy Kulikov wrote:
> Structure msm_audio_stats is copied to userland with some fields unitialized.
> It leads to leaking of contents of kernel stack memory.
> Also struct msm_audio_config has field "unused" of type array of 3 elements,
> not 4.  Instead of this, initialize field "type".
> 
> Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
> ---
>  drivers/staging/dream/qdsp5/audio_aac.c |    3 ++-

{sigh}

I'd really like to just drop this whole driver as I feel it's _way_
behind whatever anyone is really using "in the wild".

Actually, I doubt that anyone even uses this thing, do they?

Any objection to me just dropping the drivers/staging/dream/ tree?
People should be working on the chipset-specific driver tree here
instead, right?

Pavel, it looks like you're not doing any dream work anymore, any
problems with me dropping it?

thanks,

greg k-h

  reply	other threads:[~2010-10-28 20:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-28 20:01 [PATCH 1/8] staging: dream: fix information leak to userland Vasiliy Kulikov
2010-10-28 20:45 ` Greg KH [this message]
2010-10-28 20:58   ` Pavel Machek
2010-10-28 21:08     ` Greg KH
2010-10-29  1:32       ` Bryan Huntsman
2010-10-29  1:38         ` Greg KH
2010-10-29 18:27           ` Bryan Huntsman
2010-10-29 19:40             ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101028204509.GC22785@kroah.com \
    --to=greg@kroah.com \
    --cc=arnd@arndb.de \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=ibm@android.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=san@android.com \
    --cc=segooon@gmail.com \
    --cc=swetland@google.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox