From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934566Ab0J1Upy (ORCPT ); Thu, 28 Oct 2010 16:45:54 -0400 Received: from kroah.org ([198.145.64.141]:48535 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758532Ab0J1Upn (ORCPT ); Thu, 28 Oct 2010 16:45:43 -0400 Date: Thu, 28 Oct 2010 13:45:09 -0700 From: Greg KH To: Vasiliy Kulikov , Iliyan Malchev , Pavel Machek , Brian Swetland , San Mehat Cc: kernel-janitors@vger.kernel.org, Tejun Heo , devel@driverdev.osuosl.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Arnd Bergmann Subject: Re: [PATCH 1/8] staging: dream: fix information leak to userland Message-ID: <20101028204509.GC22785@kroah.com> References: <1288296098-18936-1-git-send-email-segooon@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1288296098-18936-1-git-send-email-segooon@gmail.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 29, 2010 at 12:01:37AM +0400, Vasiliy Kulikov wrote: > Structure msm_audio_stats is copied to userland with some fields unitialized. > It leads to leaking of contents of kernel stack memory. > Also struct msm_audio_config has field "unused" of type array of 3 elements, > not 4. Instead of this, initialize field "type". > > Signed-off-by: Vasiliy Kulikov > --- > drivers/staging/dream/qdsp5/audio_aac.c | 3 ++- {sigh} I'd really like to just drop this whole driver as I feel it's _way_ behind whatever anyone is really using "in the wild". Actually, I doubt that anyone even uses this thing, do they? Any objection to me just dropping the drivers/staging/dream/ tree? People should be working on the chipset-specific driver tree here instead, right? Pavel, it looks like you're not doing any dream work anymore, any problems with me dropping it? thanks, greg k-h