Re: [PATCH 1/8] staging: dream: fix information leak to userland

[Greg KH <greg@kroah.com>]

On Thu, Oct 28, 2010 at 10:58:31PM +0200, Pavel Machek wrote:
> Hi!
> 
> > > Structure msm_audio_stats is copied to userland with some fields unitialized.
> > > It leads to leaking of contents of kernel stack memory.
> > > Also struct msm_audio_config has field "unused" of type array of 3 elements,
> > > not 4.  Instead of this, initialize field "type".
> > > 
> > > Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
> > > ---
> > >  drivers/staging/dream/qdsp5/audio_aac.c |    3 ++-
> > 
> > {sigh}
> > 
> > I'd really like to just drop this whole driver as I feel it's _way_
> > behind whatever anyone is really using "in the wild".
> > 
> > Actually, I doubt that anyone even uses this thing, do they?
> 
> Not sure, you should definitely talk to codeaurora folks.
> 
> > Any objection to me just dropping the drivers/staging/dream/ tree?
> > People should be working on the chipset-specific driver tree here
> > instead, right?
> 
> codeaurora people should know...

Which specific ones?  No one seems to be contributing to the
drivers/staging/dream/ anymore, and there are a number of out-of-tree
dream trees floating around now.

> > Pavel, it looks like you're not doing any dream work anymore, any
> > problems with me dropping it?
> 
> Too busy to do any real work on Dream, sorry :-(.

Ok, I think I'll just drop it unless someone screams.

thanks,

greg k-h