From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Michal Marek <mmarek@suse.cz>,
linux-kbuild@vger.kernel.org,
Toralf Foerster <toralf.foerster@gmx.de>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>,
Hiromu Yakura <hiromu1996@gmail.com>
Subject: [PATCH 2/5] [PATCH 2/5] kconfig: Fix variable name typo %prompts in streamline_config.pl
Date: Fri, 29 Oct 2010 01:43:12 -0400 [thread overview]
Message-ID: <20101029054423.808049416@goodmis.org> (raw)
In-Reply-To: 20101029054310.790179545@goodmis.org
[-- Attachment #1: 0002-kconfig-Fix-variable-name-typo-prompts-in-streamline.patch --]
[-- Type: text/plain, Size: 1588 bytes --]
From: hiromu yagura <hiromu1996@gmail.com>
When I added "use strict;" to streamline_config.pl, I saw the following
warnings:
> Global symbol "%prompt" requires explicit package name at
scripts/kconfig/streamline_config.pl line 183.
> Global symbol "%prompt" requires explicit package name at
scripts/kconfig/streamline_config.pl line 368.
The declaration of %prompt was incorrect, and should have been %prompts.
Cc: Toralf Foerster <toralf.foerster@gmx.de>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Signed-off-by: Hiromu Yakura <hiromu1996@gmail.com>
LKML-Reference: <1281845597.11566.5.camel@camp10-laptop>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
scripts/kconfig/streamline_config.pl | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/kconfig/streamline_config.pl b/scripts/kconfig/streamline_config.pl
index cc10bcf..3c63aa9 100644
--- a/scripts/kconfig/streamline_config.pl
+++ b/scripts/kconfig/streamline_config.pl
@@ -188,7 +188,7 @@ sub read_kconfig {
# configs without prompts must be selected
} elsif ($state ne "NONE" && /^\s*tristate\s\S/) {
# note if the config has a prompt
- $prompt{$config} = 1;
+ $prompts{$config} = 1;
# Check for if statements
} elsif (/^if\s+(.*\S)\s*$/) {
@@ -373,7 +373,7 @@ while ($repeat) {
parse_config_dep_select $depends{$config};
}
- if (defined($prompt{$config}) || !defined($selects{$config})) {
+ if (defined($prompts{$config}) || !defined($selects{$config})) {
next;
}
--
1.7.1
next prev parent reply other threads:[~2010-10-29 5:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-29 5:43 [PATCH 0/5] [GIT PULL] kconfig: Fixes to make localmodconfig Steven Rostedt
2010-10-29 5:43 ` [PATCH 1/5] [PATCH 1/5] kconfig: Make localmodconfig handle environment variables Steven Rostedt
2010-10-30 0:26 ` Arnaud Lacombe
2010-10-30 1:27 ` Steven Rostedt
2010-10-31 22:05 ` Arnaud Lacombe
2010-11-09 0:49 ` Steven Rostedt
2010-11-25 15:45 ` Michal Marek
2010-11-25 16:21 ` Arnaud Lacombe
2010-11-25 16:37 ` Michal Marek
2010-10-29 5:43 ` Steven Rostedt [this message]
2010-10-29 5:43 ` [PATCH 3/5] [PATCH 3/5] kconfig: Fix missing declaration of variable $dir in streamline_config.pl Steven Rostedt
2010-10-29 5:43 ` [PATCH 4/5] [PATCH 4/5] kconfig: Fix streamline_config to read multi line deps in Kconfig files Steven Rostedt
2010-10-29 5:43 ` [PATCH 5/5] [PATCH 5/5] kconfig: Have streamline_config process menuconfigs too Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101029054423.808049416@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=hiromu1996@gmail.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=toralf.foerster@gmx.de \
--cc=torvalds@linux-foundation.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox