Re: [PATCH] Fix bug in FUSE where the attribute cache for a file was not cleared when a file is opened with O_TRUNC.

Andrew Morton
2010-10-30T00:03:30Z

On Fri, 29 Oct 2010 16:41:40 -0700 Ken Sumrall <ksumrall@android.com> wrote:

> Signed-off-by: Ken Sumrall <ksumrall@android.com>
> ---
> fs/fuse/file.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/fs/fuse/file.c b/fs/fuse/file.c
> index c822458..4fbe62c 100644
> --- a/fs/fuse/file.c
> +++ b/fs/fuse/file.c
> @@ -134,6 +134,7 @@ EXPORT_SYMBOL_GPL(fuse_do_open);
> void fuse_finish_open(struct inode *inode, struct file *file)
> {
> struct fuse_file *ff = file->private_data;
> + struct fuse_conn *fc = get_fuse_conn(inode);
>
> if (ff->open_flags & FOPEN_DIRECT_IO)
> file->f_op = &fuse_direct_io_file_operations;
> @@ -141,6 +142,8 @@ void fuse_finish_open(struct inode *inode, struct file *file)
> invalidate_inode_pages2(inode->i_mapping);
> if (ff->open_flags & FOPEN_NONSEEKABLE)
> nonseekable_open(inode, file);
> + if (fc->atomic_o_trunc && (file->f_flags & O_TRUNC))
> + fuse_invalidate_attr(inode);
> }
>
> int fuse_open_common(struct inode *inode, struct file *file, bool isdir)

What were the user-visible effects of this bug?