From: Philippe De Muyter <phdm@macqel.be>
To: Greg Ungerer <gerg@snapgear.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
linux-m68k@vger.kernel.org, dhowells@redhat.com,
gerg@uclinux.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][resend] m68k,m68knommu: Do not include linux/hardirq.h in asm/irqflags.h
Date: Sat, 30 Oct 2010 07:08:08 +0200 [thread overview]
Message-ID: <20101030050808.GA26197@frolo.macqel> (raw)
In-Reply-To: <4CCB434A.7010400@snapgear.com>
Greg, Geert,
On Sat, Oct 30, 2010 at 07:57:30AM +1000, Greg Ungerer wrote:
>
> Hi Geert,
>
> On 30/10/10 02:31, Geert Uytterhoeven wrote:
>> On Fri, Oct 29, 2010 at 16:06, Greg Ungerer<gerg@snapgear.com> wrote:
>>> Philippe DeMuyter noticed this build failure with Linus' current git
>>> tree. I think it is m68k clean too. If all are ok with it I'll
>>> pass it directly to Linus.
>>
>> Sorry, I saw his patch before, but had no spare cycles left for testing.
>>
>> Unfortunately that breaks CONFIG_MMU=y:
>>
>> arch/m68k/include/asm/irqflags.h: In function ‘arch_local_irq_enable’:
>> arch/m68k/include/asm/irqflags.h:43: error: implicit declaration of
>> function ‘hardirq_count’
Oops. I am sorry.
>>
>> But if you protect the #include<linux/hardirq.h> by #ifdef
>> CONFIG_MMU, I'm happy with
>> it.
>
> Thanks, I'll rework it with that.
Thanks to both of you
Philippe
prev parent reply other threads:[~2010-10-30 5:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4CCAD4E8.8040801@snapgear.com>
2010-10-29 16:31 ` [PATCH][resend] m68k,m68knommu: Do not include linux/hardirq.h in asm/irqflags.h Geert Uytterhoeven
2010-10-29 21:57 ` Greg Ungerer
2010-10-30 5:08 ` Philippe De Muyter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101030050808.GA26197@frolo.macqel \
--to=phdm@macqel.be \
--cc=dhowells@redhat.com \
--cc=geert@linux-m68k.org \
--cc=gerg@snapgear.com \
--cc=gerg@uclinux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox