From: Andrew Morton <akpm@linux-foundation.org>
To: Dan Magenheimer <dan.magenheimer@oracle.com>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@lst.de>,
Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: Ping? RE: [GIT PULL] mm/vfs/fs:cleancache for 2.6.37 merge window
Date: Sat, 30 Oct 2010 12:06:32 -0700 [thread overview]
Message-ID: <20101030120632.40345d0d.akpm@linux-foundation.org> (raw)
In-Reply-To: <7b34b3ea-9436-4077-a35e-a5eaabd59813@default>
On Wed, 27 Oct 2010 11:37:47 -0700 (PDT) Dan Magenheimer <dan.magenheimer@oracle.com> wrote:
> Ping? I hope you are still considering this. If not or if
> there are any questions I can answer, please let me know.
What's happened here is that the patchset has gone through its
iterations and a few people have commented and then after a while,
nobody had anything to say about the code so nobody said anything more.
But silence doesn't mean acceptance - it just means that nobody had
anything to say.
I think I looked at the earlier iterations, tried to understand the
point behind it all, made a few code suggestions and eventually tuned
out. At that time (and hence at this time) I just cannot explain to
myself why we would want to merge this code.
All new code is a cost/benefit decision. The costs are pretty well
known: larger codebase, more code for us and our "customers" to
maintain and support, etc. That the code pokes around in vfs and
various filesystems does increase those costs a little.
But the extent of the benefits to our users aren't obvious to me. The
code is still xen-specific, I believe? If so, that immediately reduces
the benefit side by a large amount simply because of the reduced
audience.
We did spend some time trying to get this wired up to zram so that the
feature would be potentially useful to *all* users, thereby setting the
usefulness multiplier back to 1.0. But I don't recall that anything
came of this?
I also don't know how useful the code is to its intended
micro-audience: xen users!
So can we please revisit all this from the top level? Jeremy, your
input would be valuable. Christoph, I recall that you had technical
objections - can you please repeat those?
It's the best I can do to kick this along, sorry.
next prev parent reply other threads:[~2010-10-30 19:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-21 15:21 [GIT PULL] mm/vfs/fs:cleancache for 2.6.37 merge window Dan Magenheimer
2010-10-21 15:36 ` Lin Ming
2010-10-21 15:57 ` gene heskett
2010-10-27 18:37 ` Ping? " Dan Magenheimer
2010-10-30 19:06 ` Andrew Morton [this message]
2010-10-30 20:49 ` Jeremy Fitzhardinge
2010-10-31 2:19 ` Dan Magenheimer
2011-01-19 16:42 ` Dan Magenheimer
2011-02-17 20:14 ` PING? cleancache for 2.6.39 window? Dan Magenheimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101030120632.40345d0d.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dan.magenheimer@oracle.com \
--cc=hch@lst.de \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox