drivers/media/IR/ir-keytable.c::ir_getkeycode - 'retval' may be used uninitialized

drivers/media/IR/ir-keytable.c::ir_getkeycode - 'retval' may be used uninitialized

[Stefan Richter]

Commit 9f470095068e "Input: media/IR - switch to using new keycode
interface" added the following build warning:

drivers/media/IR/ir-keytable.c: In function 'ir_getkeycode':
drivers/media/IR/ir-keytable.c:363: warning: 'retval' may be used uninitialized in this function

It is due to an actual bug but I don't know the fix.
-- 
Stefan Richter
-=====-==-=- =-=- =====
http://arcgraph.de/sr/

Re: drivers/media/IR/ir-keytable.c::ir_getkeycode - 'retval' may be used uninitialized

[Dmitry Torokhov]

On Sunday, October 31, 2010 10:51:21 am Stefan Richter wrote:
> Commit 9f470095068e "Input: media/IR - switch to using new keycode
> interface" added the following build warning:
> 
> drivers/media/IR/ir-keytable.c: In function 'ir_getkeycode':
> drivers/media/IR/ir-keytable.c:363: warning: 'retval' may be used uninitialized in this function
> 
> It is due to an actual bug but I don't know the fix.
> 

The patch below should fix it. I wonder if Linus released -rc1 yet...

-- 
Dmitry

Input: ir-keytable - fix uninitialized variable warning

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>

We were forgetting to set up proper return value in success path causing
ir_getkeycode() to fail intermittently:

drivers/media/IR/ir-keytable.c: In function 'ir_getkeycode':
drivers/media/IR/ir-keytable.c:363: warning: 'retval' may be used
uninitialized in this function

Reported-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
---

 drivers/media/IR/ir-keytable.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)


diff --git a/drivers/media/IR/ir-keytable.c b/drivers/media/IR/ir-keytable.c
index 9186b45..f7fafff 100644
--- a/drivers/media/IR/ir-keytable.c
+++ b/drivers/media/IR/ir-keytable.c
@@ -389,6 +389,8 @@ static int ir_getkeycode(struct input_dev *dev,
 	ke->len = sizeof(entry->scancode);
 	memcpy(ke->scancode, &entry->scancode, sizeof(entry->scancode));
 
+	retval = 0;
+
 out:
 	spin_unlock_irqrestore(&rc_tab->lock, flags);
 	return retval;

Re: drivers/media/IR/ir-keytable.c::ir_getkeycode - 'retval' may be used uninitialized

[Jarod Wilson]

On Sun, Oct 31, 2010 at 6:18 PM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> On Sunday, October 31, 2010 10:51:21 am Stefan Richter wrote:
>> Commit 9f470095068e "Input: media/IR - switch to using new keycode
>> interface" added the following build warning:
>>
>> drivers/media/IR/ir-keytable.c: In function 'ir_getkeycode':
>> drivers/media/IR/ir-keytable.c:363: warning: 'retval' may be used uninitialized in this function
>>
>> It is due to an actual bug but I don't know the fix.
>>
>
> The patch below should fix it. I wonder if Linus released -rc1 yet...

Looks like it missed rc1.

> Input: ir-keytable - fix uninitialized variable warning
>
> From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>
> We were forgetting to set up proper return value in success path causing
> ir_getkeycode() to fail intermittently:
>
> drivers/media/IR/ir-keytable.c: In function 'ir_getkeycode':
> drivers/media/IR/ir-keytable.c:363: warning: 'retval' may be used
> uninitialized in this function
>
> Reported-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
> Signed-off-by: Dmitry Torokhov <dtor@mail.ru>

Acked-by: Jarod Wilson <jarod@redhat.com>


-- 
Jarod Wilson
jarod@wilsonet.com

Re: drivers/media/IR/ir-keytable.c::ir_getkeycode - 'retval' may be used uninitialized

[Dmitry Torokhov]

On Tue, Nov 02, 2010 at 12:04:56PM -0400, Jarod Wilson wrote:
> On Sun, Oct 31, 2010 at 6:18 PM, Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
> > On Sunday, October 31, 2010 10:51:21 am Stefan Richter wrote:
> >> Commit 9f470095068e "Input: media/IR - switch to using new keycode
> >> interface" added the following build warning:
> >>
> >> drivers/media/IR/ir-keytable.c: In function 'ir_getkeycode':
> >> drivers/media/IR/ir-keytable.c:363: warning: 'retval' may be used uninitialized in this function
> >>
> >> It is due to an actual bug but I don't know the fix.
> >>
> >
> > The patch below should fix it. I wonder if Linus released -rc1 yet...
> 
> Looks like it missed rc1.
> 

Nope, I see it there, 47c5ba53bc5e5f88b5d1bbb97acd25afc27f74eb ;)

-- 
Dmitry

Re: drivers/media/IR/ir-keytable.c::ir_getkeycode - 'retval' may be used uninitialized

[Jarod Wilson]

On Tue, Nov 2, 2010 at 12:24 PM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> On Tue, Nov 02, 2010 at 12:04:56PM -0400, Jarod Wilson wrote:
>> On Sun, Oct 31, 2010 at 6:18 PM, Dmitry Torokhov
>> <dmitry.torokhov@gmail.com> wrote:
>> > On Sunday, October 31, 2010 10:51:21 am Stefan Richter wrote:
>> >> Commit 9f470095068e "Input: media/IR - switch to using new keycode
>> >> interface" added the following build warning:
>> >>
>> >> drivers/media/IR/ir-keytable.c: In function 'ir_getkeycode':
>> >> drivers/media/IR/ir-keytable.c:363: warning: 'retval' may be used uninitialized in this function
>> >>
>> >> It is due to an actual bug but I don't know the fix.
>> >>
>> >
>> > The patch below should fix it. I wonder if Linus released -rc1 yet...
>>
>> Looks like it missed rc1.
>>
>
> Nope, I see it there, 47c5ba53bc5e5f88b5d1bbb97acd25afc27f74eb ;)

Oh, damn. Sorry for the noise... I blame it on my cold... :)

-- 
Jarod Wilson
jarod@wilsonet.com