From: Andy Whitcroft <apw@canonical.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Vladislav Bolkhovitin <vst@vlnb.net>
Subject: Re: New 2.6.36 checkpatch complaints about leading whitespace
Date: Mon, 1 Nov 2010 04:10:03 +0000 [thread overview]
Message-ID: <20101101040611.GA5850@penfold> (raw)
In-Reply-To: <AANLkTi=sR+wTN1MSRZLW1qB99ybGgOTbUJuw8drtbwA5@mail.gmail.com>
On Sat, Oct 30, 2010 at 11:35:22AM +0200, Bart Van Assche wrote:
> Hello Andy,
>
> Apparently the checkpatch.pl script as included in 2.6.36 complains if
> continued lines start with whitespace. An example:
>
> [ ... ]
> +#if defined(MACRO_NAME_1) || defined(MACRO_NAME_2) \
> + || defined(MACRO_NAME_3)
> [ ... ]
>
> checkpatch.pl reports the following warning for the above patch excerpt:
>
> WARNING: please, no space for starting a line,
> excluding comments
>
> Is that a feature or an unintended side effect of recent checkpatch changes ?
My personal expectation would be for that second line to be indented
with a tab. But I might be convinced otherwise?
-apw
next prev parent reply other threads:[~2010-11-01 4:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-30 9:35 New 2.6.36 checkpatch complaints about leading whitespace Bart Van Assche
2010-11-01 4:10 ` Andy Whitcroft [this message]
2010-11-01 7:29 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101101040611.GA5850@penfold \
--to=apw@canonical.com \
--cc=bvanassche@acm.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vst@vlnb.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox