From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752692Ab0KARmo (ORCPT ); Mon, 1 Nov 2010 13:42:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:23653 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752444Ab0KARml (ORCPT ); Mon, 1 Nov 2010 13:42:41 -0400 Date: Mon, 1 Nov 2010 15:19:37 -0200 From: Marcelo Tosatti To: Vasiliy Kulikov Cc: Jan Kiszka , kernel-janitors@vger.kernel.org, Avi Kivity , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [patch v2] x86: kvm: x86: fix information leak to userland Message-ID: <20101101171937.GA4484@amt.cnet> References: <1288447871-7715-1-git-send-email-segooon@gmail.com> <4CCC2D11.7090109@web.de> <20101030153147.GA14169@albatros> <4CCC3DC2.6090505@web.de> <20101030185447.GA7629@albatros> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101030185447.GA7629@albatros> User-Agent: Mutt/1.5.20 (2009-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 30, 2010 at 10:54:47PM +0400, Vasiliy Kulikov wrote: > Structures kvm_vcpu_events, kvm_debugregs, kvm_pit_state2 and > kvm_clock_data are copied to userland with some padding and reserved > fields unitialized. It leads to leaking of contents of kernel stack > memory. We have to initialize them to zero. > > In patch v1 Jan Kiszka suggested to fill reserved fields with zeros > instead of memset'ting the whole struct. It makes sense as these > fields are explicitly marked as padding. No more fields need zeroing. > > Signed-off-by: Vasiliy Kulikov > --- > Compile tesed only. > > arch/x86/kvm/x86.c | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-) Applied, thanks.