From: Greg KH <gregkh@suse.de>
To: Haiyang Zhang <haiyangz@linuxonhyperv.com>
Cc: haiyangz@microsoft.com, hjanssen@microsoft.com,
linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
virtualization@lists.osdl.org
Subject: Re: [PATCH 03/10] staging: hv: Convert camel cased struct fields in hv.h to lower cases
Date: Mon, 1 Nov 2010 10:43:10 -0700 [thread overview]
Message-ID: <20101101174310.GA12632@suse.de> (raw)
In-Reply-To: <1288630429-12330-1-git-send-email-haiyangz@linuxonhyperv.com>
On Mon, Nov 01, 2010 at 09:53:45AM -0700, Haiyang Zhang wrote:
> From: Haiyang Zhang <haiyangz@microsoft.com>
>
> Convert camel cased struct fields in hv.h to lower cases
>
> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
> Signed-off-by: Hank Janssen <hjanssen@microsoft.com>
Why did I get two different copies of some of these patches? Are they
different?
> /* The one and only */
> -struct hv_context gHvContext = {
> - .SynICInitialized = false,
> - .HypercallPage = NULL,
> - .SignalEventParam = NULL,
> - .SignalEventBuffer = NULL,
> +struct hv_context g_hv_context = {
What is the "g_" for? Why are you keeping the unneeded, and unwanted
hungarian notation around? Please don't do that.
thanks,
greg k-h
next prev parent reply other threads:[~2010-11-01 17:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-01 16:53 [PATCH 03/10] staging: hv: Convert camel cased struct fields in hv.h to lower cases Haiyang Zhang
2010-11-01 16:53 ` [PATCH 04/10] staging: hv: Convert camel cased local variables in hv.c " Haiyang Zhang
2010-11-01 16:53 ` [PATCH 06/10] staging: hv: Convert camel cased local variables in osd.c " Haiyang Zhang
2010-11-01 16:53 ` [PATCH 07/10] staging: hv: Convert camel cased functions " Haiyang Zhang
2010-11-01 16:53 ` [PATCH 09/10] staging: hv: Convert camel cased local variables in ring_buffer.c " Haiyang Zhang
2010-11-01 17:43 ` Greg KH [this message]
2010-11-01 18:27 ` [PATCH 03/10] staging: hv: Convert camel cased struct fields in hv.h " Haiyang Zhang
2010-11-01 18:39 ` Greg KH
2010-11-01 20:48 ` Haiyang Zhang
-- strict thread matches above, loose matches on Subject: below --
2010-11-08 22:04 [PATCH 01/10] staging: hv: Convert camel cased struct fields in channel_mgmt.h " Haiyang Zhang
2010-11-08 22:04 ` [PATCH 02/10] staging: hv: Convert camel cased struct fields in hv_api.h " Haiyang Zhang
2010-11-08 22:04 ` [PATCH 03/10] staging: hv: Convert camel cased struct fields in hv.h " Haiyang Zhang
2010-11-01 20:46 [PATCH 01/10] staging: hv: Convert camel cased struct fields in channel_mgmt.h " Haiyang Zhang
2010-11-01 20:46 ` [PATCH 02/10] staging: hv: Convert camel cased struct fields in hv_api.h " Haiyang Zhang
2010-11-01 20:46 ` [PATCH 03/10] staging: hv: Convert camel cased struct fields in hv.h " Haiyang Zhang
2010-11-01 16:31 [PATCH 01/10] staging: hv: Convert camel cased struct fields in channel_mgmt.h " Haiyang Zhang
2010-11-01 16:31 ` [PATCH 02/10] staging: hv: Convert camel cased struct fields in hv_api.h " Haiyang Zhang
2010-11-01 16:31 ` [PATCH 03/10] staging: hv: Convert camel cased struct fields in hv.h " Haiyang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101101174310.GA12632@suse.de \
--to=gregkh@suse.de \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@linuxonhyperv.com \
--cc=haiyangz@microsoft.com \
--cc=hjanssen@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox