From: Greg KH <gregkh@suse.de>
To: Jiri Slaby <jslaby@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, jirislaby@gmail.com,
"[cleanups]"@suse.de, "Dr. Werner Fink" <werner@suse.de>,
Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [PATCH 1/1] console: add /proc/consoles
Date: Wed, 3 Nov 2010 09:13:42 -0700 [thread overview]
Message-ID: <20101103161342.GA4942@suse.de> (raw)
In-Reply-To: <1288798509-23550-1-git-send-email-jslaby@suse.cz>
On Wed, Nov 03, 2010 at 04:35:09PM +0100, Jiri Slaby wrote:
> It allows users to see what consoles are currently known to the system
> and with what flags.
>
> It is based on Werner's patch, the part about traversing fds was
> removed, the code was moved to kernel/printk.c, where consoles are
> handled and it makes more sense to me.
Why kernel/printk.c? I don't think that makes sense, it's just a random
proc file, so why not put it into something like fs/proc/ instead?
Does it rely on any functions in the printk.c file?
thanks,
greg k-h
next parent reply other threads:[~2010-11-03 16:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1288798509-23550-1-git-send-email-jslaby@suse.cz>
2010-11-03 16:13 ` Greg KH [this message]
2010-11-03 16:16 ` [PATCH 1/1] console: add /proc/consoles Jiri Slaby
2010-11-03 16:22 ` Greg KH
2010-11-03 16:25 ` Jiri Slaby
2010-11-03 17:39 ` Greg KH
2010-11-03 20:03 ` Jiri Slaby
2010-11-03 21:12 ` Greg KH
2010-11-04 9:57 ` Jiri Slaby
2010-11-04 13:17 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101103161342.GA4942@suse.de \
--to=gregkh@suse.de \
--cc="[cleanups]"@suse.de \
--cc=akpm@linux-foundation.org \
--cc=jirislaby@gmail.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
--cc=werner@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox