Re: [PATCH 1/1] usb: gadget: goku_udc: add registered flag bit

[Greg KH <gregkh@suse.de>]

On Wed, Nov 03, 2010 at 06:02:38PM +0000, Andy Whitcroft wrote:
> The commit below cleaned up error handling, in part by introducing a
> registered flag bit.  This however was not added to the device
> structure leding to build failures:
> 
>   commit 319feaabb6c7ccd90da6e3207563c265da7d21ae
>   Author: Dan Carpenter <error27@gmail.com>
>   Date:   Tue Oct 5 18:55:34 2010 +0200
> 
>     usb: gadget: goku_udc: Fix error path
> 
> Add the missing registered flag bit.


Dan, is this patch below the correct fix?  Or should we be looking at
some other flag?

[Andy, please always cc: the original patch author when reporting
problems, to not do so is a bit rude and causes others (i.e. me) extra
work.]

thanks,

greg k-h


> 
> Signed-off-by: Andy Whitcroft <apw@canonical.com>
> ---
>  drivers/usb/gadget/goku_udc.h |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/usb/gadget/goku_udc.h b/drivers/usb/gadget/goku_udc.h
> index 566cb23..e7e0c69 100644
> --- a/drivers/usb/gadget/goku_udc.h
> +++ b/drivers/usb/gadget/goku_udc.h
> @@ -251,7 +251,8 @@ struct goku_udc {
>  					got_region:1,
>  					req_config:1,
>  					configured:1,
> -					enabled:1;
> +					enabled:1,
> +					registered:1;
>  
>  	/* pci state used to access those endpoints */
>  	struct pci_dev			*pdev;
> -- 
> 1.7.1