* [PATCH 1/1] usb: gadget: goku_udc: add registered flag bit
@ 2010-11-03 18:02 Andy Whitcroft
2010-11-03 18:23 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Andy Whitcroft @ 2010-11-03 18:02 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: David Brownell, linux-usb, linux-kernel, Andy Whitcroft
The commit below cleaned up error handling, in part by introducing a
registered flag bit. This however was not added to the device
structure leding to build failures:
commit 319feaabb6c7ccd90da6e3207563c265da7d21ae
Author: Dan Carpenter <error27@gmail.com>
Date: Tue Oct 5 18:55:34 2010 +0200
usb: gadget: goku_udc: Fix error path
Add the missing registered flag bit.
Signed-off-by: Andy Whitcroft <apw@canonical.com>
---
drivers/usb/gadget/goku_udc.h | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/gadget/goku_udc.h b/drivers/usb/gadget/goku_udc.h
index 566cb23..e7e0c69 100644
--- a/drivers/usb/gadget/goku_udc.h
+++ b/drivers/usb/gadget/goku_udc.h
@@ -251,7 +251,8 @@ struct goku_udc {
got_region:1,
req_config:1,
configured:1,
- enabled:1;
+ enabled:1,
+ registered:1;
/* pci state used to access those endpoints */
struct pci_dev *pdev;
--
1.7.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 1/1] usb: gadget: goku_udc: add registered flag bit
2010-11-03 18:02 [PATCH 1/1] usb: gadget: goku_udc: add registered flag bit Andy Whitcroft
@ 2010-11-03 18:23 ` Greg KH
2010-11-03 19:12 ` Dan Carpenter
2010-11-09 20:27 ` Andy Whitcroft
0 siblings, 2 replies; 5+ messages in thread
From: Greg KH @ 2010-11-03 18:23 UTC (permalink / raw)
To: Andy Whitcroft, Dan Carpenter
Cc: Rahul Ruikar, David Brownell, linux-usb, linux-kernel
On Wed, Nov 03, 2010 at 06:02:38PM +0000, Andy Whitcroft wrote:
> The commit below cleaned up error handling, in part by introducing a
> registered flag bit. This however was not added to the device
> structure leding to build failures:
>
> commit 319feaabb6c7ccd90da6e3207563c265da7d21ae
> Author: Dan Carpenter <error27@gmail.com>
> Date: Tue Oct 5 18:55:34 2010 +0200
>
> usb: gadget: goku_udc: Fix error path
>
> Add the missing registered flag bit.
Dan, is this patch below the correct fix? Or should we be looking at
some other flag?
[Andy, please always cc: the original patch author when reporting
problems, to not do so is a bit rude and causes others (i.e. me) extra
work.]
thanks,
greg k-h
>
> Signed-off-by: Andy Whitcroft <apw@canonical.com>
> ---
> drivers/usb/gadget/goku_udc.h | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/gadget/goku_udc.h b/drivers/usb/gadget/goku_udc.h
> index 566cb23..e7e0c69 100644
> --- a/drivers/usb/gadget/goku_udc.h
> +++ b/drivers/usb/gadget/goku_udc.h
> @@ -251,7 +251,8 @@ struct goku_udc {
> got_region:1,
> req_config:1,
> configured:1,
> - enabled:1;
> + enabled:1,
> + registered:1;
>
> /* pci state used to access those endpoints */
> struct pci_dev *pdev;
> --
> 1.7.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/1] usb: gadget: goku_udc: add registered flag bit
2010-11-03 18:23 ` Greg KH
@ 2010-11-03 19:12 ` Dan Carpenter
2010-11-03 19:18 ` Greg KH
2010-11-09 20:27 ` Andy Whitcroft
1 sibling, 1 reply; 5+ messages in thread
From: Dan Carpenter @ 2010-11-03 19:12 UTC (permalink / raw)
To: Greg KH
Cc: Andy Whitcroft, Rahul Ruikar, David Brownell, linux-usb,
linux-kernel
On Wed, Nov 03, 2010 at 11:23:14AM -0700, Greg KH wrote:
> On Wed, Nov 03, 2010 at 06:02:38PM +0000, Andy Whitcroft wrote:
> > The commit below cleaned up error handling, in part by introducing a
> > registered flag bit. This however was not added to the device
> > structure leding to build failures:
> >
> > commit 319feaabb6c7ccd90da6e3207563c265da7d21ae
> > Author: Dan Carpenter <error27@gmail.com>
> > Date: Tue Oct 5 18:55:34 2010 +0200
> >
> > usb: gadget: goku_udc: Fix error path
> >
> > Add the missing registered flag bit.
>
>
> Dan, is this patch below the correct fix? Or should we be looking at
> some other flag?
>
Yes. This was my fault. I forgot to send you that part of the patch.
Acked-by: Dan Carpenter <error27@gmail.com>
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] usb: gadget: goku_udc: add registered flag bit
2010-11-03 19:12 ` Dan Carpenter
@ 2010-11-03 19:18 ` Greg KH
0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2010-11-03 19:18 UTC (permalink / raw)
To: Dan Carpenter, Andy Whitcroft, Rahul Ruikar, David Brownell,
linux-usb, linux-kernel
On Wed, Nov 03, 2010 at 09:12:38PM +0200, Dan Carpenter wrote:
> On Wed, Nov 03, 2010 at 11:23:14AM -0700, Greg KH wrote:
> > On Wed, Nov 03, 2010 at 06:02:38PM +0000, Andy Whitcroft wrote:
> > > The commit below cleaned up error handling, in part by introducing a
> > > registered flag bit. This however was not added to the device
> > > structure leding to build failures:
> > >
> > > commit 319feaabb6c7ccd90da6e3207563c265da7d21ae
> > > Author: Dan Carpenter <error27@gmail.com>
> > > Date: Tue Oct 5 18:55:34 2010 +0200
> > >
> > > usb: gadget: goku_udc: Fix error path
> > >
> > > Add the missing registered flag bit.
> >
> >
> > Dan, is this patch below the correct fix? Or should we be looking at
> > some other flag?
> >
>
> Yes. This was my fault. I forgot to send you that part of the patch.
>
> Acked-by: Dan Carpenter <error27@gmail.com>
Thanks for the quick response, I'll queue this up.
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] usb: gadget: goku_udc: add registered flag bit
2010-11-03 18:23 ` Greg KH
2010-11-03 19:12 ` Dan Carpenter
@ 2010-11-09 20:27 ` Andy Whitcroft
1 sibling, 0 replies; 5+ messages in thread
From: Andy Whitcroft @ 2010-11-09 20:27 UTC (permalink / raw)
To: Greg KH
Cc: Dan Carpenter, Rahul Ruikar, David Brownell, linux-usb,
linux-kernel
On Wed, Nov 03, 2010 at 11:23:14AM -0700, Greg KH wrote:
> On Wed, Nov 03, 2010 at 06:02:38PM +0000, Andy Whitcroft wrote:
> > The commit below cleaned up error handling, in part by introducing a
> > registered flag bit. This however was not added to the device
> > structure leding to build failures:
> >
> > commit 319feaabb6c7ccd90da6e3207563c265da7d21ae
> > Author: Dan Carpenter <error27@gmail.com>
> > Date: Tue Oct 5 18:55:34 2010 +0200
> >
> > usb: gadget: goku_udc: Fix error path
> >
> > Add the missing registered flag bit.
>
>
> Dan, is this patch below the correct fix? Or should we be looking at
> some other flag?
>
> [Andy, please always cc: the original patch author when reporting
> problems, to not do so is a bit rude and causes others (i.e. me) extra
> work.]
Appologies. I thought I used get_maintainers which I thought pulled in
the recent committers. More care next time.
-apw
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-11-09 20:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-03 18:02 [PATCH 1/1] usb: gadget: goku_udc: add registered flag bit Andy Whitcroft
2010-11-03 18:23 ` Greg KH
2010-11-03 19:12 ` Dan Carpenter
2010-11-03 19:18 ` Greg KH
2010-11-09 20:27 ` Andy Whitcroft
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox