[PATCH] pm_qos: Fix reversed min and max

[PATCH] pm_qos: Fix reversed min and max

[Colin Cross]

pm_qos_get_value had min and max reversed, causing all pm_qos
requests to have no effect.

Change-Id: I252c764821eac8d94de57eb482c05bf6afcea15b
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: mark gross <markgross@thegnar.org>
Cc: James Bottomley <James.Bottomley@suse.de>
Cc: stable <stable@kernel.org>
Signed-off-by: Colin Cross <ccross@android.com>
---
 kernel/pm_qos_params.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/pm_qos_params.c b/kernel/pm_qos_params.c
index 645e541..0da2837 100644
--- a/kernel/pm_qos_params.c
+++ b/kernel/pm_qos_params.c
@@ -120,10 +120,10 @@ static inline int pm_qos_get_value(struct pm_qos_object *o)
 
 	switch (o->type) {
 	case PM_QOS_MIN:
-		return plist_last(&o->requests)->prio;
+		return plist_first(&o->requests)->prio;
 
 	case PM_QOS_MAX:
-		return plist_first(&o->requests)->prio;
+		return plist_last(&o->requests)->prio;
 
 	default:
 		/* runtime check for not using enum */
-- 
1.7.3.1

Re: [PATCH] pm_qos: Fix reversed min and max

[mark gross]

On Wed, Nov 03, 2010 at 11:40:03PM -0700, Colin Cross wrote:
> pm_qos_get_value had min and max reversed, causing all pm_qos
> requests to have no effect.
sorry.

Acked-by : mark <markgross@thegnar.org>
 

--mgross
 
> Change-Id: I252c764821eac8d94de57eb482c05bf6afcea15b
> Cc: "Rafael J. Wysocki" <rjw@sisk.pl>
> Cc: mark gross <markgross@thegnar.org>
> Cc: James Bottomley <James.Bottomley@suse.de>
> Cc: stable <stable@kernel.org>
> Signed-off-by: Colin Cross <ccross@android.com>
> ---
>  kernel/pm_qos_params.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/pm_qos_params.c b/kernel/pm_qos_params.c
> index 645e541..0da2837 100644
> --- a/kernel/pm_qos_params.c
> +++ b/kernel/pm_qos_params.c
> @@ -120,10 +120,10 @@ static inline int pm_qos_get_value(struct pm_qos_object *o)
>  
>  	switch (o->type) {
>  	case PM_QOS_MIN:
> -		return plist_last(&o->requests)->prio;
> +		return plist_first(&o->requests)->prio;
>  
>  	case PM_QOS_MAX:
> -		return plist_first(&o->requests)->prio;
> +		return plist_last(&o->requests)->prio;
>  
>  	default:
>  		/* runtime check for not using enum */
> -- 
> 1.7.3.1
> 

Re: [PATCH] pm_qos: Fix reversed min and max

[Rafael J. Wysocki]

On Thursday, November 04, 2010, mark gross wrote:
> On Wed, Nov 03, 2010 at 11:40:03PM -0700, Colin Cross wrote:
> > pm_qos_get_value had min and max reversed, causing all pm_qos
> > requests to have no effect.
> sorry.
> 
> Acked-by : mark <markgross@thegnar.org>

Applied to suspend-2.6/linux-next, will push to Linus next week.

Thanks,
Rafael

  
> > Change-Id: I252c764821eac8d94de57eb482c05bf6afcea15b
> > Cc: "Rafael J. Wysocki" <rjw@sisk.pl>
> > Cc: mark gross <markgross@thegnar.org>
> > Cc: James Bottomley <James.Bottomley@suse.de>
> > Cc: stable <stable@kernel.org>
> > Signed-off-by: Colin Cross <ccross@android.com>
> > ---
> >  kernel/pm_qos_params.c |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/kernel/pm_qos_params.c b/kernel/pm_qos_params.c
> > index 645e541..0da2837 100644
> > --- a/kernel/pm_qos_params.c
> > +++ b/kernel/pm_qos_params.c
> > @@ -120,10 +120,10 @@ static inline int pm_qos_get_value(struct pm_qos_object *o)
> >  
> >  	switch (o->type) {
> >  	case PM_QOS_MIN:
> > -		return plist_last(&o->requests)->prio;
> > +		return plist_first(&o->requests)->prio;
> >  
> >  	case PM_QOS_MAX:
> > -		return plist_first(&o->requests)->prio;
> > +		return plist_last(&o->requests)->prio;
> >  
> >  	default:
> >  		/* runtime check for not using enum */
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
>