From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Henrik Rydberg <rydberg@euromail.se>
Cc: Jean Delvare <khali@linux-fr.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>
Subject: Re: [lm-sensors] [PATCH 6/8] hwmon: applesmc: Dynamic creation of fan files
Date: Thu, 4 Nov 2010 19:59:33 -0700 [thread overview]
Message-ID: <20101105025933.GE28308@ericsson.com> (raw)
In-Reply-To: <1288511434-5662-7-git-send-email-rydberg@euromail.se>
On Sun, Oct 31, 2010 at 03:50:32AM -0400, Henrik Rydberg wrote:
> With the dynamic temperature group in place, the setup of fans
> can be simplified. This patch sets up the fans dynamically, removing
> a hundred lines of code.
>
> Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
Hi Henrik,
just one minor comment.
> ---
> drivers/hwmon/applesmc.c | 188 +++++++++++-----------------------------------
> 1 files changed, 43 insertions(+), 145 deletions(-)
>
> diff --git a/drivers/hwmon/applesmc.c b/drivers/hwmon/applesmc.c
> index abbff0b..4ba20ec 100644
> --- a/drivers/hwmon/applesmc.c
> +++ b/drivers/hwmon/applesmc.c
[ ... ]
> static int applesmc_init_smcreg_try(void)
> {
> struct applesmc_registers *s = &smcreg;
> + u8 tmp[4];
Why tmp[4] if you only read one byte ?
Guenter
next prev parent reply other threads:[~2010-11-05 3:00 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-31 7:50 [PATCH 0/8] hwmon: applesmc: Dynamic configuration rewrite Henrik Rydberg
2010-10-31 7:50 ` [PATCH 1/8] hwmon: applesmc: Relax the severity of device init failure Henrik Rydberg
2010-11-02 16:03 ` [lm-sensors] " Guenter Roeck
2010-11-03 14:45 ` Henrik Rydberg
2010-10-31 7:50 ` [PATCH 2/8] hwmon: applesmc: Introduce a register lookup table Henrik Rydberg
2010-11-04 4:21 ` [lm-sensors] " Guenter Roeck
2010-11-04 8:20 ` Henrik Rydberg
2010-10-31 7:50 ` [PATCH 3/8] hwmon: applesmc: Dynamic creation of temperature files Henrik Rydberg
2010-11-05 2:23 ` [lm-sensors] " Guenter Roeck
2010-10-31 7:50 ` [PATCH 4/8] hwmon: applesmc: Handle new temperature format Henrik Rydberg
2010-11-05 2:32 ` [lm-sensors] " Guenter Roeck
2010-11-05 2:35 ` Guenter Roeck
2010-11-05 8:34 ` Henrik Rydberg
2010-10-31 7:50 ` [PATCH 5/8] hwmon: applesmc: Extract all features generically Henrik Rydberg
2010-11-05 2:50 ` [lm-sensors] " Guenter Roeck
2010-11-05 8:52 ` Henrik Rydberg
2010-10-31 7:50 ` [PATCH 6/8] hwmon: applesmc: Dynamic creation of fan files Henrik Rydberg
2010-11-05 2:59 ` Guenter Roeck [this message]
2010-11-05 8:56 ` [lm-sensors] " Henrik Rydberg
2010-10-31 7:50 ` [PATCH 7/8] hwmon: applesmc: Simplify feature sysfs handling Henrik Rydberg
2010-11-05 3:07 ` [lm-sensors] " Guenter Roeck
2010-10-31 7:50 ` [PATCH 8/8] hwmon: applesmc: Update copyright information Henrik Rydberg
2010-11-05 3:09 ` [lm-sensors] " Guenter Roeck
2010-11-05 9:00 ` Henrik Rydberg
2010-11-05 11:45 ` Guenter Roeck
2010-10-31 8:31 ` [PATCH 0/8] hwmon: applesmc: Dynamic configuration rewrite Joe Perches
2010-10-31 8:44 ` Henrik Rydberg
2010-10-31 8:55 ` Joe Perches
2010-10-31 10:05 ` Jean Delvare
2010-11-03 13:48 ` [lm-sensors] " Guenter Roeck
2010-11-03 14:43 ` Henrik Rydberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101105025933.GE28308@ericsson.com \
--to=guenter.roeck@ericsson.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox