From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 2/3] regulator: Ensure enough delay time for enabling regulator
Date: Fri, 5 Nov 2010 09:19:42 -0400 [thread overview]
Message-ID: <20101105131941.GD13709@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1288941980.16201.2.camel@mola>
On Fri, Nov 05, 2010 at 03:26:20PM +0800, Axel Lin wrote:
> - if (delay >= 1000)
> + if (delay >= 1000) {
> mdelay(delay / 1000);
> - else if (delay)
> + udelay(delay % 1000);
> + } else if (delay)
> udelay(delay);
This looks good but please change this to use { } in the else case also;
I find this very helpful for legibility.
next prev parent reply other threads:[~2010-11-05 13:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-05 7:25 [PATCH 1/3] regulator: Remove a redundant device_remove_file call in create_regulator Axel Lin
2010-11-05 7:26 ` [PATCH 2/3] regulator: Ensure enough delay time for enabling regulator Axel Lin
2010-11-05 13:19 ` Mark Brown [this message]
2010-11-05 7:27 ` [PATCH 3/3] regulator: Return proper error for regulator_register() Axel Lin
2010-11-05 13:20 ` Mark Brown
2010-11-05 13:18 ` [PATCH 1/3] regulator: Remove a redundant device_remove_file call in create_regulator Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101105131941.GD13709@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=axel.lin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox