* [PATCH] leds-net5501: taints kernel, add license
@ 2010-11-04 17:28 Randy Dunlap
2010-11-05 13:40 ` Richard Purdie
2010-11-05 21:35 ` Alessandro Zummo
0 siblings, 2 replies; 3+ messages in thread
From: Randy Dunlap @ 2010-11-04 17:28 UTC (permalink / raw)
To: lkml, torvalds; +Cc: Richard Purdie, akpm, Alessandro Zummo
From: Randy Dunlap <randy.dunlap@oracle.com>
Add MODULE_LICENSE() that matches file comments so that kernel
is not tainted.
leds_net5501: module license 'unspecified' taints kernel.
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/leds/leds-net5501.c | 2 ++
1 file changed, 2 insertions(+)
Alessandro, why does this module not have a module_exit() function?
I.e., why can it not be unloaded?
--- lnx-2637-rc1.orig/drivers/leds/leds-net5501.c
+++ lnx-2637-rc1/drivers/leds/leds-net5501.c
@@ -92,3 +92,5 @@ unmap:
}
arch_initcall(soekris_init);
+
+MODULE_LICENSE("GPL");
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] leds-net5501: taints kernel, add license
2010-11-04 17:28 [PATCH] leds-net5501: taints kernel, add license Randy Dunlap
@ 2010-11-05 13:40 ` Richard Purdie
2010-11-05 21:35 ` Alessandro Zummo
1 sibling, 0 replies; 3+ messages in thread
From: Richard Purdie @ 2010-11-05 13:40 UTC (permalink / raw)
To: Randy Dunlap, akpm; +Cc: lkml, torvalds, Alessandro Zummo
On Thu, 2010-11-04 at 10:28 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Add MODULE_LICENSE() that matches file comments so that kernel
> is not tainted.
>
> leds_net5501: module license 'unspecified' taints kernel.
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Acked-by: Richard Purdie <rpurdie@linux.intel.com>
> ---
> drivers/leds/leds-net5501.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> Alessandro, why does this module not have a module_exit() function?
> I.e., why can it not be unloaded?
>
>
> --- lnx-2637-rc1.orig/drivers/leds/leds-net5501.c
> +++ lnx-2637-rc1/drivers/leds/leds-net5501.c
> @@ -92,3 +92,5 @@ unmap:
> }
>
> arch_initcall(soekris_init);
> +
> +MODULE_LICENSE("GPL");
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] leds-net5501: taints kernel, add license
2010-11-04 17:28 [PATCH] leds-net5501: taints kernel, add license Randy Dunlap
2010-11-05 13:40 ` Richard Purdie
@ 2010-11-05 21:35 ` Alessandro Zummo
1 sibling, 0 replies; 3+ messages in thread
From: Alessandro Zummo @ 2010-11-05 21:35 UTC (permalink / raw)
To: Randy Dunlap; +Cc: lkml, torvalds, Richard Purdie, akpm, Bjarke Istrup Pedersen
On Thu, 4 Nov 2010 10:28:00 -0700
Randy Dunlap <randy.dunlap@oracle.com> wrote:
> Alessandro, why does this module not have a module_exit() function?
> I.e., why can it not be unloaded?
>
I believe there's no particular reason.
Bjarke Istrup Pedersen is taking care of this code (CCd).
--
Best regards,
Alessandro Zummo,
Tower Technologies - Torino, Italy
http://www.towertech.it
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-11-05 21:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-04 17:28 [PATCH] leds-net5501: taints kernel, add license Randy Dunlap
2010-11-05 13:40 ` Richard Purdie
2010-11-05 21:35 ` Alessandro Zummo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox