Re: [PATCH 2/4] locks: fix leaks on setlease errors

Christoph Hellwig
2010-11-01T17:41:43Z

On Mon, Nov 01, 2010 at 01:24:40PM -0400, J. Bruce Fields wrote:
> I also have patches that get rid of fl_release_private, fl_mylease, and
> (almost done) fl_change.
>
> Unless you've a better suggestion I'll probably send them out for review
> and then queue them up with other nfsd changes for 2.6.38.

Sounds good. I was also wondering if we can get rid of ->setlease
entirely. The file_lock_operations should be enough abstraction to
reject the leases in theory, but I need to look into it a bit more.