Re: nfsd changes for 2.6.37

J. Bruce Fields
2010-10-27T13:39:37Z

Arnd Bergmann wrote:
> > If you don't hold lock_flocks throughout fcntl_setlease, the flp variable
> > points to a flock that may get modified by another thread and you call
> > time_out_leases() without holding lock_flocks, which it requires.

Whoops, thanks for catching that.

On Wed, Oct 27, 2010 at 04:39:24AM -0400, Christoph Hellwig wrote:
> Do locks_alloc_lock and initialization of the heap struct file_lock
> in the caller. This also avoids an entirely useless copy of the
> lock structure. free the passed in structure if we are modifying
> an existing lock structure.

That sounds good; I'll give it a try.

--b.