Re: [PATCH 2/4] locks: fix leaks on setlease errors

Christoph Hellwig
2010-10-31T11:11:11Z

On Sat, Oct 30, 2010 at 05:31:14PM -0400, J. Bruce Fields wrote:
> We're depending on setlease to free the passed-in lease on failure.

But we would be much better to just free it in the caller. I'ts much
more natural - caller allocates, caller frees, and it's also simpler.

I'll send a patch to do so shortly, together with sorting out the
remaining nfs4d lock_manager_operations abuses. I think we're set with
that for 2.6.37, the setlease split can wait once we've sorted out the
lock freeing issue.