Re: nfsd changes for 2.6.37

Christoph Hellwig
2010-10-31T02:07:14Z

On Sat, Oct 30, 2010 at 05:25:00PM -0400, J. Bruce Fields wrote:
> We still need to do this part. I just did the minimum required to fix
> the problem--I figure splitting out a separate ->delete_lease method
> (which I agree would be cleaner) could wait till the next merge window.

I'd say please do it now. The pre-allocated file_lock changes make
the semantics inside ->setlease really nasty right now. I think it's a
dumb idea to leave it that way even for a single merge window.