From: "David Härdeman" <david@hardeman.nu>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Sean Young <sean@mess.org>,
linux-kernel@vger.kernel.org, jesse.barnes@intel.com
Subject: Re: [PATCH] Fix Winbond CIR driver initialisation
Date: Sun, 7 Nov 2010 20:00:09 +0100 [thread overview]
Message-ID: <20101107190009.GA28224@hardeman.nu> (raw)
In-Reply-To: <20101107154648.4bcdfb9f@lxorguk.ukuu.org.uk>
On Sun, Nov 07, 2010 at 03:46:48PM +0000, Alan Cox wrote:
> > A workaround is to boot with argument 8250.nr_uarts=1. This is not really
> > desirable, so this patch makes ttyS1 go away.
>
> setserial can also be used for this surely ?
That's about as user-unfriendly as the boot option.
> > + dev_info(device, "Unregistering phony serial port ttyS1\n");
> > + serial8250_unregister_port(1);
> > + ok = request_region(data->sbase, SP_IOMEM_LEN, DRVNAME);
>
> That's a hack that is only going to work on specific systems where it is
> mapped the way you expect and doing stuff behind the back of the serial
> driver.
>
> I'm not averse to a better solution but it needs to be general and
> maintainable. Is there a way to identify the presence of the windbond CIR
> device as opposed to an 8250 ?
Not sure which kind of identification you're looking for but would a PNP
id be sufficient?
--
David Härdeman
next prev parent reply other threads:[~2010-11-07 19:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-07 13:18 [PATCH] Fix Winbond CIR driver initialisation Sean Young
2010-11-07 15:46 ` Alan Cox
2010-11-07 19:00 ` David Härdeman [this message]
2010-11-10 16:40 ` Sean Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101107190009.GA28224@hardeman.nu \
--to=david@hardeman.nu \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jesse.barnes@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sean@mess.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox