From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753693Ab0KGXLd (ORCPT ); Sun, 7 Nov 2010 18:11:33 -0500 Received: from ozlabs.org ([203.10.76.45]:37881 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753120Ab0KGXLb (ORCPT ); Sun, 7 Nov 2010 18:11:31 -0500 From: Rusty Russell To: Jason Wang Subject: Re: [RESEND PATCH] virtio-net: init link state correctly Date: Mon, 8 Nov 2010 09:41:27 +1030 User-Agent: KMail/1.13.5 (Linux/2.6.35-22-generic-pae; KDE/4.5.1; i686; ; ) Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net, markmc@redhat.com, kvm@vger.kernel.org, mst@redhat.com References: <20101105094718.19101.58898.stgit@dhcp-91-158.nay.redhat.com> In-Reply-To: <20101105094718.19101.58898.stgit@dhcp-91-158.nay.redhat.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201011080941.28190.rusty@rustcorp.com.au> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 5 Nov 2010 08:17:18 pm Jason Wang wrote: > For device that supports VIRTIO_NET_F_STATUS, there's no need to > assume the link is up and we need to call nerif_carrier_off() before > querying device status, otherwise we may get wrong operstate after > diver was loaded because the link watch event was not fired as > expected. > > For device that does not support VIRITO_NET_F_STATUS, we could not get > its status through virtnet_update_status() and what we can only do is > always assuming the link is up. > > Acked-by: Michael S. Tsirkin > Signed-off-by: Jason Wang Acked-by: Rusty Russell Thanks! Rusty.