From: Rusty Russell <rusty@rustcorp.com.au>
To: virtualization@lists.linux-foundation.org
Cc: Jiri Slaby <jslaby@suse.cz>,
jirislaby@gmail.com, Amit Shah <amit.shah@redhat.com>,
"Greg Kroah-Hartman" <gregkh@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Char: virtio_console, fix memory leak
Date: Mon, 8 Nov 2010 09:58:22 +1030 [thread overview]
Message-ID: <201011080958.23163.rusty@rustcorp.com.au> (raw)
In-Reply-To: <1289034412-24278-2-git-send-email-jslaby@suse.cz>
On Sat, 6 Nov 2010 07:36:50 pm Jiri Slaby wrote:
> Stanse found that in init_vqs, memory is leaked under certain
> circumstanses (the fail path order is incorrect). Fix that by checking
> allocations in one turn and free all of them at once if some fails
> (some may be NULL, but this is OK).
Good catch, thanks!
I generally prefer the static rather than lazy method of cleanup, but
in this case it's ugly both before and after...
Applied,
Rusty.
next prev parent reply other threads:[~2010-11-07 23:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-06 9:06 [PATCH] x86: pci/xen, fix memory leak Jiri Slaby
2010-11-06 9:06 ` [PATCH] Char: virtio_console, " Jiri Slaby
2010-11-07 23:28 ` Rusty Russell [this message]
2010-11-06 9:06 ` [PATCH] IDE: ide-floppy, remove unnecessary NULL check Jiri Slaby
2010-11-06 12:00 ` Sergei Shtylyov
2010-11-06 12:10 ` Borislav Petkov
2010-11-22 19:39 ` David Miller
2010-11-06 9:06 ` [PATCH] ocfs2: fix memory leak Jiri Slaby
2010-11-18 23:42 ` Joel Becker
2010-11-08 15:34 ` [PATCH] x86: pci/xen, " Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201011080958.23163.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=amit.shah@redhat.com \
--cc=gregkh@suse.de \
--cc=jirislaby@gmail.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox