From: Andrew Morton <akpm@linux-foundation.org>
To: Ed Cashin <ecashin@coraid.com>
Cc: sage@newdream.net, yehuda@hq.newdream.net,
linux-kernel@vger.kernel.org, Tracey Dent <tdent48227@gmail.com>
Subject: Re: [Resend][PATCH 2/2] Drivers: block: aoe: Makefile: replace the use of <module>-objs with <module>-y
Date: Mon, 8 Nov 2010 13:05:43 -0800 [thread overview]
Message-ID: <20101108130543.1188a63f.akpm@linux-foundation.org> (raw)
In-Reply-To: <EDA33B3B-F9C9-4C45-B20D-C985DFC95C2F@coraid.com>
On Mon, 8 Nov 2010 10:03:24 -0500
Ed Cashin <ecashin@coraid.com> wrote:
> On Nov 6, 2010, at 2:58 PM, Tracey Dent wrote:
>
> > Changed <module>-objs to <module>-y in Makefile.
>
> Andrew Morton, hi. I don't know whether Tracey Dent is expecting
> me to push this change to Linus, but lately you've been pushing the
> aoe changes. I see similar changes in other
> drivers on the LKML, so if it looks good to you, would you mind please
> picking up this patch?
I queued both patches - I guess I'll send them to Jens.
I queued them as "unchangelogged patches". Because what the changelogs told
us was utterly obvious from reading the patch.
What the changelogs didn't tell us was _why_ the change was made. And
guess what? I don't have a clue! I just haven't been following these
kbuild minutea.
Tracey, please send a description of *why* this change is being made
and I'll add it to the changelogs. Please include that explanation in
all such patches.
next prev parent reply other threads:[~2010-11-08 21:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-06 18:58 [Resend][PATCH 1/2] Drivers: block: Makefile: replace the use of <module>-objs with <module>-y Tracey Dent
2010-11-06 18:58 ` [Resend][PATCH 2/2] Drivers: block: aoe: " Tracey Dent
2010-11-08 15:03 ` Ed Cashin
2010-11-08 21:05 ` Andrew Morton [this message]
2010-11-09 1:11 ` Stephen Rothwell
2010-11-09 13:54 ` Ed Cashin
2010-11-09 14:43 ` Stephen Rothwell
2010-11-09 2:14 ` Tracey Dent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101108130543.1188a63f.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ecashin@coraid.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sage@newdream.net \
--cc=tdent48227@gmail.com \
--cc=yehuda@hq.newdream.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox