From: Don Zickus <dzickus@redhat.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
akpm@linux-foundation.org, sergey.senozhatsky@gmail.com
Subject: Re: [PATCH] watchdog: touch_nmi_watchdog should only touch local cpu not every one
Date: Mon, 8 Nov 2010 08:38:51 -0500 [thread overview]
Message-ID: <20101108133851.GK4823@redhat.com> (raw)
In-Reply-To: <20101107220909.GF11134@nowhere>
On Sun, Nov 07, 2010 at 11:09:11PM +0100, Frederic Weisbecker wrote:
> > + /*
> > + * Using __raw here because some code paths have
> > + * preemption enabled. If preemption is enabled
> > + * then interrupts should be enabled too, in which
> > + * case we shouldn't have to worry about the watchdog
> > + * going off.
> > + */
> > + __raw_get_cpu_var(watchdog_nmi_touch) = true;
> > +
> > + touch_softlockup_watchdog();
> > +}
> > +EXPORT_SYMBOL(touch_nmi_watchdog);
>
>
>
> Did the old watchdog also touched every CPUs?
Yeah, unfortunately.
Cheers,
Don
next prev parent reply other threads:[~2010-11-08 13:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-05 1:18 [PATCH] watchdog: touch_nmi_watchdog should only touch local cpu not every one Don Zickus
2010-11-05 13:51 ` Sergey Senozhatsky
2010-11-05 19:58 ` Andrew Morton
2010-11-08 13:37 ` Don Zickus
2010-11-07 22:09 ` Frederic Weisbecker
2010-11-08 13:38 ` Don Zickus [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-12-05 3:12 [PATCH v2] watchdog: Add a sysctl to disable soft lockup detector Don Zickus
2013-12-05 20:42 ` [PATCH] watchdog: touch_nmi_watchdog should only touch local cpu not every one Ben Zhang
2013-12-16 15:55 ` Don Zickus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101108133851.GK4823@redhat.com \
--to=dzickus@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox