From: Youquan Song <youquan.song@linux.intel.com>
To: Arjan van de Ven <arjan@linux.intel.com>
Cc: Youquan Song <youquan.song@linux.intel.com>,
davej@redhat.com, venki@google.com, youquan.song@intel.com,
cpufreq@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpufreq: Fix ondemand governor powersave_bias execution time misuse
Date: Mon, 8 Nov 2010 09:45:27 -0500 [thread overview]
Message-ID: <20101108144527.GA13617@linux-youquan.bj.intel.com> (raw)
In-Reply-To: <4CD3EF31.9060909@linux.intel.com>
> On 11/5/2010 11:19 AM, Youquan Song wrote:
>> Ondemand governor use powersave_bias tunable to do aggressive power save by
>> decrease CPU average frequency. The average frequency achieve by adjust low and
>> high frequency's execution time proportion during one sample time interval.
>>
>> Current kernel, only the high frequency executes in time proportion, but the low
>> frequency wrongly execute in one whole sample time interval when powersave_bias
>> is set.
>>
>> The patch fix it by set low frequency execution time to it deserved.
>>
>> Signed-off-by: Youquan Song<youquan.song@intel.com>
>> ---
>
>
> while your patch looks correct, I think the whole feature is wonky and
> likely ought to be removed...........
powersave_bias should be a useful feature, which give user an
opportunity to set the CPU to work at wider average frequency accord to real
workload requirement, not just CPU frequency specific at P0,P1,...Pn.
At the same time, it meets end user power comsumpation requirement in
some degree.
Unfortunately, it does not work for a long time.
Thanks
-Youquan
next prev parent reply other threads:[~2010-11-08 2:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-05 15:19 [PATCH] cpufreq: Fix ondemand governor powersave_bias execution time misuse Youquan Song
2010-11-05 11:49 ` Arjan van de Ven
2010-11-08 14:45 ` Youquan Song [this message]
2010-11-08 4:32 ` Arjan van de Ven
2011-03-02 1:07 ` Andrew Morton
2011-03-02 18:58 ` Youquan Song
2011-03-02 16:00 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101108144527.GA13617@linux-youquan.bj.intel.com \
--to=youquan.song@linux.intel.com \
--cc=arjan@linux.intel.com \
--cc=cpufreq@vger.kernel.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=venki@google.com \
--cc=youquan.song@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox