[PATCH] module: Update prototype for ref_module (formerly use_module)

[PATCH] module: Update prototype for ref_module (formerly use_module)

[Anders Kaseorg]

Commit 9bea7f23952d5948f8e5dfdff4de09bb9981fb5f renamed use_module to
ref_module (and changed its return value), but forgot to update this
prototype in module.h.

Signed-off-by: Anders Kaseorg <andersk@ksplice.com>
---
 include/linux/module.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/linux/module.h b/include/linux/module.h
index aace066..caf6105 100644
--- a/include/linux/module.h
+++ b/include/linux/module.h
@@ -514,7 +514,7 @@ static inline void __module_get(struct module *module)
 #define symbol_put_addr(p) do { } while(0)
 
 #endif /* CONFIG_MODULE_UNLOAD */
-int use_module(struct module *a, struct module *b);
+int ref_module(struct module *a, struct module *b);
 
 /* This is a #define so the string doesn't get put in every .o file */
 #define module_name(mod)			\
-- 
1.7.3.1

Re: [PATCH] module: Update prototype for ref_module (formerly use_module)

[Américo Wang]

On Fri, Nov 05, 2010 at 05:05:46PM -0400, Anders Kaseorg wrote:
>Commit 9bea7f23952d5948f8e5dfdff4de09bb9981fb5f renamed use_module to
>ref_module (and changed its return value), but forgot to update this
>prototype in module.h.
>
>Signed-off-by: Anders Kaseorg <andersk@ksplice.com>

Acked-by: WANG Cong <xiyou.wangcong@gmail.com>

I am wondering why we find this after 5 months! :-/

>---
> include/linux/module.h |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/include/linux/module.h b/include/linux/module.h
>index aace066..caf6105 100644
>--- a/include/linux/module.h
>+++ b/include/linux/module.h
>@@ -514,7 +514,7 @@ static inline void __module_get(struct module *module)
> #define symbol_put_addr(p) do { } while(0)
> 
> #endif /* CONFIG_MODULE_UNLOAD */
>-int use_module(struct module *a, struct module *b);
>+int ref_module(struct module *a, struct module *b);
> 
> /* This is a #define so the string doesn't get put in every .o file */
> #define module_name(mod)			\
>-- 
>1.7.3.1
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at  http://www.tux.org/lkml/

-- 
Live like a child, think like the god.
 

Re: [PATCH] module: Update prototype for ref_module (formerly use_module)

[Rusty Russell]

On Sat, 6 Nov 2010 07:35:46 am Anders Kaseorg wrote:
> Commit 9bea7f23952d5948f8e5dfdff4de09bb9981fb5f renamed use_module to
> ref_module (and changed its return value), but forgot to update this
> prototype in module.h.

Hmm, didn't one of these go via akpm?

I'll send it along now...

Thanks!
Rusty.