From: Sean MacLennan <smaclennan@pikatech.com>
To: "Axel Lin" <axel.lin@gmail.com>
Cc: "linux-kernel" <linux-kernel@vger.kernel.org>,
"Jean Delvare" <khali@linux-fr.org>, <lm-sensors@lm-sensors.org>
Subject: Re: [PATCH] hwmon: (ad7414) Return proper error code for ad7414_probe()
Date: Mon, 8 Nov 2010 21:41:42 -0500 [thread overview]
Message-ID: <20101108214142.6e2556ac@lappy.seanm.ca> (raw)
In-Reply-To: <1289266834.14461.3.camel@mola>
On Mon, 8 Nov 2010 20:40:34 -0500
"Axel Lin" <axel.lin@gmail.com> wrote:
> [PATCH] hwmon: (ad7414) Return proper error code for ad7414_probe()
>
> Return proper error if i2c_check_functionality reports
> the adapter does not support the capability we need.
>
> Also remove unneeded initialization for err variable.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Sean MacLennan <smaclennan@pikatech.com>
> ---
> drivers/hwmon/ad7414.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hwmon/ad7414.c b/drivers/hwmon/ad7414.c
> index 1e4c21f..86d822a 100644
> --- a/drivers/hwmon/ad7414.c
> +++ b/drivers/hwmon/ad7414.c
> @@ -178,11 +178,13 @@ static int ad7414_probe(struct i2c_client
> *client, {
> struct ad7414_data *data;
> int conf;
> - int err = 0;
> + int err;
I wouldn't mind if this was "int conf, err;", but I don't mind the way
it is.
Cheers,
Sean
next prev parent reply other threads:[~2010-11-09 2:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-09 1:40 [PATCH] hwmon: (ad7414) Return proper error code for ad7414_probe() Axel Lin
2010-11-09 2:41 ` Sean MacLennan [this message]
2010-11-09 2:44 ` [lm-sensors] " Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101108214142.6e2556ac@lappy.seanm.ca \
--to=smaclennan@pikatech.com \
--cc=axel.lin@gmail.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox