public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: linux-kernel@vger.kernel.org
Cc: rostedt@goodmis.org, fweisbec@gmail.com, mingo@redhat.com,
	chris@chris-wilson.co.uk
Subject: Re: [PATCH 2/4] tracing: introduce trace_set_clr_module_event
Date: Tue, 9 Nov 2010 19:23:20 +0800	[thread overview]
Message-ID: <20101109112320.GA21828@localhost.localdomain> (raw)
In-Reply-To: <1289293967-31761-2-git-send-email-yuanhan.liu@linux.intel.com>

On Tue, Nov 09, 2010 at 05:12:45PM +0800, Yuanhan Liu wrote:

[ snip ]

> +	for_each_token(token, p) {
> +		for_each_event(call, start, end) {
> +			if (strcmp(token, "*") == 0 ||
> +			    strcmp(token, call->name) == 0) 
> +				ftrace_event_enable_disable(call, set);
> +			else
> +				pr_warning("Failed to find trace event: %s "
> +					   "in module %s\n", token, mod->name);
Oops, sorry for this obvious error, will fix it.

Besides that, any comments? 

Thanks.

--
Yuanhan Liu
> +		
> +		}
> +	}
> +	kfree(buf);
> +	return 0;
> +}
> +EXPORT_SYMBOL_GPL(trace_set_clr_module_event);
> +
> +
>  #else
>  static int trace_module_notify(struct notifier_block *self,
>  			       unsigned long val, void *data)
> -- 
> 1.7.2.3

  reply	other threads:[~2010-11-09 11:23 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-09  9:12 [PATCH 1/4] tracing: introduce for_each_token macro Yuanhan Liu
2010-11-09  9:12 ` [PATCH 2/4] tracing: introduce trace_set_clr_module_event Yuanhan Liu
2010-11-09 11:23   ` Yuanhan Liu [this message]
2010-11-09 11:27     ` Chris Wilson
2010-11-09 13:20       ` Yuanhan Liu
2010-11-09 13:31         ` Chris Wilson
2010-11-09 13:56           ` Steven Rostedt
2010-11-09 14:06             ` Yuanhan Liu
2010-11-09 13:59           ` Yuanhan Liu
2010-11-09 14:01             ` Steven Rostedt
2010-11-09 14:11           ` [PATCH] Delegate unknown module parameters to interested parties Chris Wilson
2010-11-09 14:39             ` Steven Rostedt
2010-11-10  5:51               ` Rusty Russell
2010-11-10 13:56                 ` Steven Rostedt
2010-11-11  0:35                   ` Rusty Russell
2010-11-11  1:05                     ` Steven Rostedt
2010-11-09  9:12 ` [PATCH 3/4] tracing: update trace-events-sample.c Yuanhan Liu
2010-11-09  9:12 ` [PATCH 4/4] tracing: update the trace/events.txt documentation Yuanhan Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101109112320.GA21828@localhost.localdomain \
    --to=yuanhan.liu@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox