Re: [PATCH] drivers/hwmon: Use pr_fmt and pr_

Guenter Roeck
2010-10-20T16:44:26Z

Hi Jean,
On Wed, Oct 20, 2010 at 12:38:35PM -0400, Jean Delvare wrote:
[ ... ]
>
> I'm still using quilt so it means quite some manual work for me. Probably
> I could automate part of it, and I would if it was happening
> frequently. But as it stands it's rather rare.
>
I tried quilt, but dumped it in favor of git. Personal preference, maybe,
but I seem to get along with git much better than with quilt.

> OK. Well, only two of "my" drivers are affected by Joe's patch (it87
> and pcf8591), so if you prefer the split variant, you could pick all
> the individual patches except these two, and I take these two.
>
Ok, let's do that.

> But first of all, I really would like the pr_fmt issue do be sorted
> out. I don't like the idea of having to redefine it in every driver,
> when it seems easy to avoid that. Joe?
>
Agreed, especially since it doesn't seem to be used in many of the drivers.

Guenter