Re: [PATCH 32/32] drivers/hwmon/w83781d.c: Use pr_fmt and pr_

Joe Perches
2010-11-09T10:04:07Z

On Tue, 2010-11-09 at 10:39 +0100, Jean Delvare wrote:
> On Tue, 19 Oct 2010 23:51:56 -0700, Joe Perches wrote:
> > Added #define pr_fmt KBUILD_MODNAME ": " fmt
> > Converted printks to pr_<level>
> > Coalesced any long formats
> > Removed prefixes from formats
> >
> > Signed-off-by: Joe Perches <joe@perches.com>
> > ---
> > drivers/hwmon/w83781d.c | 29 ++++++++++++++---------------
[]
> > @@ -1811,7 +1812,7 @@ w83781d_isa_found(unsigned short address)
> > if (inb_p(address + 2) != val
> > || inb_p(address + 3) != val
> > || inb_p(address + 7) != val) {
> > - pr_debug("w83781d: Detection failed at step 1\n");
> > + pr_debug("Detection failed at step 1\n");
> I think this would be the right time to change this to:
> pr_debug("Detection failed at step %d\n", 1);
> and do the same for all 6 messages below, so that the compiler can
> store the string only once in the binary.

Fine by me.