Re: [PATCH] drivers/hwmon: Use pr_fmt and pr_

Joe Perches
2010-10-20T16:54:24Z

On Wed, 2010-10-20 at 09:49 -0700, Guenter Roeck wrote:
> On Wed, Oct 20, 2010 at 11:59:23AM -0400,
> Joe Perches wrote:
> [ ... ]
> > Anyway, I'd like to sort it out eventually.
> > For now, I just add the #define pr_fmt, with
> > a long term goal of removing them all and using
> > a different mechanism to remove the duplicated
> > prefix string altogether from the formats and
> > save some text.
> I don't mind individual pr_fmt defines as long as they are used.
> However, that is not the case in many of the patches.
> Just adding a pr_fmt define to a file without using it doesn't make sense to me.

kernel.h has the equivalent of:

#define pr_<level>(fmt, arg...) printk(KERN_<level> pr_fmt(fmt), ##arg)

so the added "#define pr_fmt(fmt)..."s are used
wherever pr_<level> is done.