From: Kees Cook <kees.cook@canonical.com>
To: linux-kernel@vger.kernel.org
Cc: Andy Whitcroft <apw@canonical.com>
Subject: [linux-next] automatic use of checkpatch.pl for security?
Date: Tue, 9 Nov 2010 09:33:57 -0800 [thread overview]
Message-ID: <20101109173357.GA5876@outflux.net> (raw)
Hi,
In an effort to continue the constification work, it'd be nice to
not accidentally introduce regressions or add additional work. Since
checkpatch.pl already knows to warn about a lot of things including const
structures, it would be great to have all commits going through linux-next
(or something) have to pass at least a subset of checkpatch.pl's checks.
For example, Lionel Debroux pointed out to me that looking at the last
1000 commits, there are a lot of warnings, including things like:
WARNING: struct dma_map_ops should normally be const
#499: FILE: arch/mips/mm/dma-default.c:301:
+static struct dma_map_ops mips_default_dma_map_ops = {
Can we add some kind of automatic checking to actually give checkpatch.pl
some real teeth for at least some of its checks?
-Kees
--
Kees Cook
Ubuntu Security Team
next reply other threads:[~2010-11-09 17:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-09 17:33 Kees Cook [this message]
2010-11-09 17:44 ` [linux-next] automatic use of checkpatch.pl for security? David Daney
2010-11-09 17:59 ` Kees Cook
2010-11-09 20:49 ` Lionel Debroux
2010-11-10 18:28 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101109173357.GA5876@outflux.net \
--to=kees.cook@canonical.com \
--cc=apw@canonical.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox