Re: [PATCH V2] include/linux/kernel.h: Move logging bits to include/linux/logging.h

["Ted Ts'o" <tytso@mit.edu>]

On Tue, Nov 09, 2010 at 11:17:56AM -0800, Joe Perches wrote:
> 
> Differences in logging.h to original kernel.h
> were done for cleanliness and checkpatch.

Yet another reason why I detest mindless use of checkpatch.  And as a
maintainer, I balance the value of code movement patches in particular
against how it breaks other people's patches, and how unless I do
*very* careful review, people can sneak in changes that could either
(a) break code accidentally, or even (b) introduce security holes
deliberately.  (i.e., if I was in charge of the cyber warfare division
of some large nation state, a really obvious way of trying to insert
vulnerabilities into code is to send "cleanup" patches that move code
around, and introduce some subtle buffer overrun or other
security change.)

As a result, I spend extra time reviewing patches that move code
around, and I **really** dislike patches that try to do any kind of
cleanup (checkpatch.pl or otherwise) at the same time as they move
code around.

	       	    	    	      	   - Ted