public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Borislav Petkov <bp@amd64.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Jesper Juhl <jj@chaosbits.net>,
	amd64-microcode@amd64.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -tip] microcode, AMD: Cleanup code a bit
Date: Wed, 10 Nov 2010 09:31:21 +0100	[thread overview]
Message-ID: <20101110083121.GD3341@elte.hu> (raw)
In-Reply-To: <20101102175248.GA25781@aftab>


* Borislav Petkov <bp@amd64.org> wrote:

> get_ucode_data is a memcpy() wrapper which always returns 0. Move it
> into the header and make it an inline. Remove all code checking its
> return value and turn it into a void.
> 
> There should be no functionality change resulting from this patch.
> 
> Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
> ---
>  arch/x86/include/asm/microcode.h |    6 ++++++
>  arch/x86/kernel/microcode_amd.c  |   25 +++++--------------------
>  2 files changed, 11 insertions(+), 20 deletions(-)

Hm, what tree is this against - it doesnt apply here:

 Hunk #3 FAILED at 180.
 Hunk #4 succeeded at 195 (offset -1 lines).
 Hunk #5 succeeded at 211 (offset -1 lines).
 1 out of 5 hunks FAILED -- rejects in file arch/x86/kernel/microcode_amd.c

Thanks,

	Ingo

  reply	other threads:[~2010-11-10  8:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-02 17:52 [PATCH -tip] microcode, AMD: Cleanup code a bit Borislav Petkov
2010-11-10  8:31 ` Ingo Molnar [this message]
2010-11-10 11:33   ` Borislav Petkov
2010-11-10 13:22     ` Ingo Molnar
2010-11-10 13:59       ` Borislav Petkov
2010-11-10 14:08         ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101110083121.GD3341@elte.hu \
    --to=mingo@elte.hu \
    --cc=amd64-microcode@amd64.org \
    --cc=bp@amd64.org \
    --cc=hpa@zytor.com \
    --cc=jj@chaosbits.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox