Re: [RFC/PATCH 1/2] Add usb_endpoint_descriptor to be part of the struct usb_ep

[David Brown <davidb@codeaurora.org>]

On Sun, Oct 03, 2010 at 12:35:07PM -0400, Alan Stern wrote:

> > Signed-off-by: Tatyana Linder <tlinder@codeaurora.org>
> ...
> 
> > diff --git a/drivers/usb/gadget/file_storage.c b/drivers/usb/gadget/file_storage.c
> > index a857b7a..6264fba 100644
> > --- a/drivers/usb/gadget/file_storage.c
> > +++ b/drivers/usb/gadget/file_storage.c
> > @@ -3,6 +3,7 @@
> >   *
> >   * Copyright (C) 2003-2008 Alan Stern
> >   * All rights reserved.
> > + * Copyright (C) 2010 Code Aurora Forum. All rights reserved.
> >   *
> >   * Redistribution and use in source and binary forms, with or without
> >   * modification, are permitted provided that the following conditions
> 
> Speaking for myself only, I don't think people should add their own 
> copyright notices in files to which they have not made substantial 
> changes.  A little code motion and a small API adjustment don't seem 
> like large enough changes to justify this.  Some of the other files in 
> this patch have even smaller changes!

BTW, we agree on this.  People aren't supposed to be putting these
copyrights in, but they've gotten used to it up until now.

Tatyana, please be careful to not insert a Code Aurora Forum copyright
unless you change a significant portion of the file.

David