public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Paul Turner <pjt@google.com>
To: linux-kernel@vger.kernel.org
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Ingo Molnar <mingo@elte.hu>,
	Srivatsa Vaddagiri <vatsa@in.ibm.com>,
	Chris Friesen <cfriesen@nortel.com>,
	Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>,
	Pierre Bourdon <pbourdon@excellency.fr>,
	Paul Turner <pjt@google.com>,
	Bharata B Rao <bharata@linux.vnet.ibm.com>,
	Karl Rister <kmr@us.ibm.com>,
	Balbir Singh <balbir@linux.vnet.ibm.com>
Subject: [tg_shares_up rewrite v2 00/11] reducing overhead for tg->shares distribution
Date: Wed, 10 Nov 2010 19:50:05 -0800	[thread overview]
Message-ID: <20101111035005.443640006@google.com> (raw)

This is v2 of the tg_shares_up re-write previously posted at:
http://lkml.org/lkml/2010/10/16/17

The key idea behind this patchset is an idea of Peter Zijlstra to compute
global loads as a function of local averages avoiding the cpu-cpu interactions
which previously plagued tg_shares_up.

Not much 'material' has changed since v1 since results seem favourable/stable.
The only functional change is a bug fix in the wake_affine path where the v1
was using the waking task's group shares at all levels instead of the per-level
task_group.

Changes:
sched-rework-tg_shares_up.patch
- use owning tg->shares value in effective_load
- remove redundant cfs_rq_of() in {enqueue,dequeue}_entity

sched-tg-add-shares_window_sysctl.patch
- update comment on sysctl interpretation

sched-tg-fix-update_cfs_load.patch
- update comment to reflect periods instead of foldings (more intuitive)

Some motivation again:
24 thread Intel box, 150 active cgroups, multiple threads/group, system load at ~90% (sample size=10s):
tip:
     2.64%  [k] tg_shares_up <!>
     0.15%  [k] __set_se_shares

patched:
     0.02%  [k] update_cfs_load
     0.01%  [k] update_cpu_load
     0.00%  [k] update_cfs_shares

Fairness coverage for the above at: http://rs5.risingnet.net/~pjt/patches/shares_data_v1.txt

Thanks,

- Paul

-- 


             reply	other threads:[~2010-11-11  3:56 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-11  3:50 Paul Turner [this message]
2010-11-11  3:50 ` [tg_shares_up rewrite v2 01/11] sched: rewrite tg_shares_up Paul Turner
2010-11-11  3:50 ` [tg_shares_up rewrite v2 02/11] sched: on-demand (active) cfs_rq list Paul Turner
2010-11-11  3:50 ` [tg_shares_up rewrite v2 03/11] sched: make tg_shares_up() walk on-demand Paul Turner
2010-11-11  3:50 ` [tg_shares_up rewrite v2 04/11] sched: fix load corruption from update_cfs_shares Paul Turner
2010-11-11  3:50 ` [tg_shares_up rewrite v2 05/11] sched: fix update_cfs_load synchronization Paul Turner
2010-11-11  3:50 ` [tg_shares_up rewrite v2 06/11] sched: hierarchal order on shares update list Paul Turner
2010-11-11  3:50 ` [tg_shares_up rewrite v2 07/11] sched: add sysctl_sched_shares_window Paul Turner
2010-11-11  3:50 ` [tg_shares_up rewrite v2 08/11] sched: update shares on idle_balance Paul Turner
2010-11-11  3:50 ` [tg_shares_up rewrite v2 09/11] sched: demand based update_cfs_load() Paul Turner
2010-11-11  3:50 ` [tg_shares_up rewrite v2 10/11] sched: allow update_cfs_load to update global load Paul Turner
2010-11-11  4:47   ` David Miller
2010-11-11  4:50     ` David Miller
2010-11-11 11:13       ` Paul Turner
2010-11-11 12:37       ` Peter Zijlstra
2010-11-11  3:50 ` [tg_shares_up rewrite v2 11/11] sched: update tg->shares after cpu.shares write Paul Turner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101111035005.443640006@google.com \
    --to=pjt@google.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=balbir@linux.vnet.ibm.com \
    --cc=bharata@linux.vnet.ibm.com \
    --cc=cfriesen@nortel.com \
    --cc=kmr@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=pbourdon@excellency.fr \
    --cc=svaidy@linux.vnet.ibm.com \
    --cc=vatsa@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox