From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Stefan Achatz <erazor_de@users.sourceforge.net>
Cc: "Randy Dunlap" <rdunlap@xenotime.net>,
"Jiri Kosina" <jkosina@suse.cz>,
"Bruno Prémont" <bonbons@linux-vserver.org>,
"Stephane Chatty" <chatty@enac.fr>,
"Don Prince" <dhprince-devel@yahoo.co.uk>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-input@vger.kernel.org
Subject: Re: [PATCH] HID: roccat: Add support for Roccat Kone[+]
Date: Thu, 11 Nov 2010 01:00:16 -0800 [thread overview]
Message-ID: <20101111090015.GG24415@core.coreip.homeip.net> (raw)
In-Reply-To: <1287943025.2623.16.camel@neuromancer>
Hi Stefan,
On Sun, Oct 24, 2010 at 07:57:05PM +0200, Stefan Achatz wrote:
> +
> +static int koneplus_create_sysfs_attributes(struct usb_interface *intf)
> +{
> + int retval;
> +
> + retval = sysfs_create_group(&intf->dev.kobj, &koneplus_attribute_group);
> + if (retval)
> + goto exit_1;
> +
> + retval = sysfs_create_bin_file(&intf->dev.kobj,
> + &koneplus_profile_settings_attr);
> + if (retval)
> + goto exit_2;
> +
> + retval = sysfs_create_bin_file(&intf->dev.kobj,
> + &koneplus_profile1_settings_attr);
> + if (retval)
> + goto exit_3;
> +
...
> +
> + retval = sysfs_create_bin_file(&intf->dev.kobj,
> + &koneplus_sensor_attr);
> + if (retval)
> + goto exit_17;
> +
I think we are ready to sysfs_binary_attribute_group ;) Please add it to
sysfs code and send it to GregKH.
Thanks.
--
Dmitry
prev parent reply other threads:[~2010-11-11 9:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-24 17:57 [PATCH] HID: roccat: Add support for Roccat Kone[+] Stefan Achatz
2010-11-04 18:25 ` Jiri Kosina
2010-11-05 17:42 ` Stefan Achatz
2010-11-05 18:01 ` Jiri Kosina
2010-11-06 18:51 ` [PATCH 1/3] HID: roccat: Reducing number of functions in kone and pyra drivers Stefan Achatz
2010-11-06 18:52 ` [PATCH 2/3] HID: roccat: declaring meaning of pack pragma usage in koneplus driver Stefan Achatz
2010-11-06 18:53 ` [PATCH 3/3] HID: roccat: declaring meaning of pack pragma usage in kone and pyra driver Stefan Achatz
2010-11-12 19:16 ` [PATCH] HID: roccat: Add support for Roccat Kone[+] Stefan Achatz
2010-11-05 17:53 ` [PATCH] HID: roccat: Using bin-attribute->private to reduce code duplication Stefan Achatz
2010-11-11 9:00 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101111090015.GG24415@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=bonbons@linux-vserver.org \
--cc=chatty@enac.fr \
--cc=dhprince-devel@yahoo.co.uk \
--cc=erazor_de@users.sourceforge.net \
--cc=jkosina@suse.cz \
--cc=linux-doc@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox