From: Rusty Russell <rusty@rustcorp.com.au>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Jason Wang <jasowang@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
davem@davemloft.net, markmc@redhat.com, kvm@vger.kernel.org
Subject: Re: [RESEND PATCH] virtio-net: init link state correctly
Date: Thu, 11 Nov 2010 11:15:05 +1030 [thread overview]
Message-ID: <201011111115.06161.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20101110150823.GA5622@redhat.com>
On Thu, 11 Nov 2010 01:38:23 am Michael S. Tsirkin wrote:
> On Mon, Nov 08, 2010 at 09:41:27AM +1030, Rusty Russell wrote:
> > On Fri, 5 Nov 2010 08:17:18 pm Jason Wang wrote:
> > > For device that supports VIRTIO_NET_F_STATUS, there's no need to
> > > assume the link is up and we need to call nerif_carrier_off() before
> > > querying device status, otherwise we may get wrong operstate after
> > > diver was loaded because the link watch event was not fired as
> > > expected.
> > >
> > > For device that does not support VIRITO_NET_F_STATUS, we could not get
> > > its status through virtnet_update_status() and what we can only do is
> > > always assuming the link is up.
> > >
> > > Acked-by: Michael S. Tsirkin <mst@redhat.com>
> > > Signed-off-by: Jason Wang <jasowang@redhat.com>
> >
> > Acked-by: Rusty Russell <rusty@rustcorp.com.au>
> >
> > Thanks!
> > Rusty.
>
> Rusty, just to verify: who shall be queueing this up?
Sorry, that was sloppy of me; was meant for DaveM to take.
Sending explicitly now...
Rusty.
prev parent reply other threads:[~2010-11-11 0:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-05 9:47 [RESEND PATCH] virtio-net: init link state correctly Jason Wang
2010-11-07 23:11 ` Rusty Russell
2010-11-10 15:08 ` Michael S. Tsirkin
2010-11-11 0:45 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201011111115.06161.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=davem@davemloft.net \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markmc@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox