Re: [PATCH] x86, acpi: Handle all SRAT cpu entries even have cpu num limitation

Yinghai Lu
2010-12-15T22:58:03Z

On 12/15/2010 02:53 PM, H. Peter Anvin wrote:
> On 12/15/2010 02:40 PM, Yinghai Lu wrote:
>> On 12/15/2010 02:01 PM, H. Peter Anvin wrote:
>>> On 11/13/2010 05:38 PM, Yinghai Lu wrote:
>>>> Index: linux-2.6/arch/x86/kernel/acpi/boot.c
>>>> ===================================================================
>>>> --- linux-2.6.orig/arch/x86/kernel/acpi/boot.c
>>>> +++ linux-2.6/arch/x86/kernel/acpi/boot.c
>>>> @@ -198,6 +198,13 @@ static void __cpuinit acpi_register_lapi
>>>> {
>>>> unsigned int ver = 0;
>>>>
>>>> +#ifdef CONFIG_X86_64
>>>> + if (id >= (MAX_APICS-1)) {
>>>> + printk(KERN_INFO PREFIX "skipped apicid that is too big\n");
>>>> + return;
>>>> + }
>>>> +#endif
>>>> +
>>>> if (!enabled) {
>>>> ++disabled_cpus;
>>>> return;
>>>
>>> Why the #ifdef?
>>
>> try to limit the affects to 32bit's bunch sub arch etc.
>>
>
> I really, really don't like that... we want more unification, not less...

ok, will try to remove them.

Yinghai