From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Don Zickus <dzickus@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>,
fweisbec@gmail.com, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/2] x86: Remove old nmi_watchdog
Date: Fri, 12 Nov 2010 21:04:09 +0300 [thread overview]
Message-ID: <20101112180409.GA20425@lenovo> (raw)
In-Reply-To: <1289578944-28564-1-git-send-email-dzickus@redhat.com>
On Fri, Nov 12, 2010 at 11:22:22AM -0500, Don Zickus wrote:
>
> Ingo asked me to remove the old nmi_watchdog to minimize the amount of
> code duplication we have to do for recent fixes. All the functionality
> needed by the old nmi watchdog should be available in perf now.
>
Hi Don, moving out old nmi-watchdog in a sake of new perf based one is
definitely a win I believe. And I didn't find anything suspicious in patch
series as well.
Though it's a bit pity that we eventually drop old io-apic based watchdog ;)
I never used it personally since apic on mine cpu works well enough but still
I think the io-apic watchdog code was pretty interesting to read and I believe
it worked well with old pit timer.
> Compile tested for 32/64 bit with the lockup detector turned on and off.
> Tested on 32/64 bit machines to make sure they still boot properly.
ok, great done!
Cyrill
prev parent reply other threads:[~2010-11-12 18:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-12 16:22 [PATCH 0/2] x86: Remove old nmi_watchdog Don Zickus
2010-11-12 16:22 ` [PATCH 1/2] x86, nmi_watchdog: remove the " Don Zickus
2010-11-18 14:05 ` [tip:perf/core] x86, nmi_watchdog: Remove " tip-bot for Don Zickus
2010-11-18 19:11 ` Yinghai Lu
2010-11-18 19:39 ` Yinghai Lu
2010-11-18 20:02 ` Don Zickus
2010-11-18 20:07 ` Yinghai Lu
2010-11-12 16:22 ` [PATCH 2/2] x86, nmi_watchdog: remove all stub function calls from " Don Zickus
2010-11-18 14:05 ` [tip:perf/core] x86, nmi_watchdog: Remove " tip-bot for Don Zickus
2010-11-12 18:04 ` Cyrill Gorcunov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101112180409.GA20425@lenovo \
--to=gorcunov@gmail.com \
--cc=dzickus@redhat.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox