From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753473Ab0KLR3M (ORCPT <rfc822;w@1wt.eu>);
	Fri, 12 Nov 2010 12:29:12 -0500
Received: from mail-ww0-f44.google.com ([74.125.82.44]:57013 "EHLO
	mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752746Ab0KLR3L (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 12 Nov 2010 12:29:11 -0500
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=sender:from:to:subject:date:user-agent:cc:references:in-reply-to
         :organization:mime-version:content-type:content-transfer-encoding
         :message-id;
        b=MifpJqx/dZcns34ke2M/rPyzc2+2euEMXaYlRe6LlXPbN+rC5sD9s5k47KDtaTxKtv
         srw8NXP/nTKG4oA3FUVu2tFoa208nGZMYVw9d4fDrDNcOMj4BYtsdWF7Qlns3TeXjZWg
         WU7wH5I9sAqCReFzRbwUJkAwe7Hc/CMRUsavc=
From: Florian Fainelli <florian@openwrt.org>
To: alsa-devel@alsa-project.org
Subject: Re: [PATCH] sound/mixart: avoid redefining {readl,write}_{le,be} accessors
Date: Fri, 12 Nov 2010 18:29:11 +0100
User-Agent: KMail/1.13.5 (Linux/2.6.35-22-server; KDE/4.5.1; x86_64; ; )
Cc: linux-kernel@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.de>
References: <201011091829.08664.florian@openwrt.org>
In-Reply-To: <201011091829.08664.florian@openwrt.org>
Organization: OpenWrt
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201011121829.11914.florian@openwrt.org>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday 09 November 2010 18:29:08 Florian Fainelli wrote:
> From: Florian Fainelli <florian@openwrt.org>

Takashi, do you have any comments on this patch?

Thanks!

> 
> If the platform already provides a definition for these accessors
> do not redefine them. The warning was caught on MIPS.
> 
> Signed-off-by: Florian Fainelli <florian@openwrt.org>
> ---
> diff --git a/sound/pci/mixart/mixart_hwdep.h
> b/sound/pci/mixart/mixart_hwdep.h index a46f508..812e288 100644
> --- a/sound/pci/mixart/mixart_hwdep.h
> +++ b/sound/pci/mixart/mixart_hwdep.h
> @@ -25,11 +25,21 @@
> 
>  #include <sound/hwdep.h>
> 
> +#ifndef readl_be
>  #define readl_be(x) be32_to_cpu(__raw_readl(x))
> +#endif
> +
> +#ifndef writel_be
>  #define writel_be(data,addr) __raw_writel(cpu_to_be32(data),addr)
> +#endif
> 
> +#ifndef readl_le
>  #define readl_le(x) le32_to_cpu(__raw_readl(x))
> +#endif
> +
> +#ifndef writel_le
>  #define writel_le(data,addr) __raw_writel(cpu_to_le32(data),addr)
> +#endif
> 
>  #define MIXART_MEM(mgr,x)	((mgr)->mem[0].virt + (x))
>  #define MIXART_REG(mgr,x)	((mgr)->mem[1].virt + (x))