From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Bruno Randolf <br1@einfach.org>
Cc: kosaki.motohiro@jp.fujitsu.com,
Stefan Richter <stefanr@s5r6.in-berlin.de>,
Andrew Morton <akpm@linux-foundation.org>,
randy.dunlap@oracle.com, peterz@infradead.org,
blp@cs.stanford.edu, linux-kernel@vger.kernel.org,
Lars_Ericsson@telia.com, kevin.granade@gmail.com,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH v6] Add generic exponentially weighted moving average (EWMA) function
Date: Sun, 14 Nov 2010 14:07:10 +0900 (JST) [thread overview]
Message-ID: <20101114133029.E008.A69D9226@jp.fujitsu.com> (raw)
In-Reply-To: <201011121044.40274.br1@einfach.org>
> > Why do ewma_init() and ewma_add() return their first argument? They look
> > to me like they can be straight-forward void functions.
>
> You are right, for ewma_init() it does not make sense.
>
> For ewma_add() I think it does. This has been discussed before (e.g.
> http://linux.derkeiler.com/Mailing-Lists/Kernel/2010-10/msg09124.html).
> Some people might want to get the value when they add a sample by using
> ewma_get(ewma_add(&ewma, val));
ewma_add(&ewma, val);
ewma_get(&ewma);
is enough simpler and cleaner. I don't oppse this :)
next prev parent reply other threads:[~2010-11-14 5:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-11 3:47 [PATCH v6] Add generic exponentially weighted moving average (EWMA) function Bruno Randolf
2010-11-11 3:53 ` Andrew Morton
2010-11-11 3:59 ` Bruno Randolf
2010-11-11 4:02 ` Andrew Morton
2010-11-11 5:21 ` Bruno Randolf
2010-11-11 18:17 ` Stefan Richter
2010-11-12 1:44 ` Bruno Randolf
2010-11-14 5:07 ` KOSAKI Motohiro [this message]
2010-11-14 8:51 ` Stefan Richter
2010-11-15 2:10 ` Bruno Randolf
2010-11-15 7:38 ` Stefan Richter
2010-11-15 7:50 ` Bruno Randolf
2010-11-15 8:46 ` Peter Zijlstra
-- strict thread matches above, loose matches on Subject: below --
2010-10-22 1:51 Bruno Randolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101114133029.E008.A69D9226@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=Lars_Ericsson@telia.com \
--cc=akpm@linux-foundation.org \
--cc=blp@cs.stanford.edu \
--cc=br1@einfach.org \
--cc=kevin.granade@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=peterz@infradead.org \
--cc=randy.dunlap@oracle.com \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox